Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UT's for Controller #164

Merged
merged 1 commit into from
Nov 29, 2022
Merged

Add UT's for Controller #164

merged 1 commit into from
Nov 29, 2022

Conversation

asifdxtreme
Copy link
Collaborator

What type of PR is this?
/kind enhancement

What this PR does / why we need it:
Add UT's for Controller

@codecov-commenter
Copy link

Codecov Report

Merging #164 (1087ba3) into main (d9bdcbf) will increase coverage by 9.22%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #164      +/-   ##
==========================================
+ Coverage   61.37%   70.59%   +9.22%     
==========================================
  Files           6        6              
  Lines        1517     1517              
==========================================
+ Hits          931     1071     +140     
+ Misses        466      446      -20     
+ Partials      120        0     -120     
Flag Coverage Δ
unittests 70.59% <ø> (+9.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/drivers/csi/csiutil.go 64.47% <0.00%> (+5.26%) ⬆️
pkg/drivers/cpi/cpiutil.go 88.67% <0.00%> (+5.66%) ⬆️
controllers/vspherecloudconfig_controller.go 57.57% <0.00%> (+9.09%) ⬆️
pkg/session/session.go 81.17% <0.00%> (+9.41%) ⬆️
controllers/vdoconfig_controller.go 69.59% <0.00%> (+9.50%) ⬆️
pkg/client/dynamic_client.go 75.00% <0.00%> (+10.60%) ⬆️

Impacted file tree graph

Copy link
Contributor

@aggarwalta aggarwalta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Collaborator

@ridaz ridaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks.

@asifdxtreme asifdxtreme merged commit 234984c into main Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants