node-agent config for data mover micro service pod resources #8143
Conversation
Signed-off-by: Lyndon-Li <[email protected]>
Lyndon-Li
force-pushed
the
data-mover-ms-pod-resource-limit
branch
from
bdbe66c to
627e2fe
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8143 +/- ##
==========================================
- Coverage 59.07% 59.06% -0.02%
==========================================
Files 364 364
Lines 30298 30321 +23
==========================================
+ Hits 17899 17909 +10
- Misses 10956 10969 +13
Partials 1443 1443 ☔ View full report in Codecov by Sentry. |
| } | ||
|
|
||
| type PodResources struct { | ||
| CPURequest string `json:"cpuRequest,omitempty"` |
There was a problem hiding this comment.
Should we also allow users to set requests and limits for emphemeral-storage as well ?
There was a problem hiding this comment.
Do you mean the root file system of the pod? We already have the backup repo config for users to set the cacheLimit which consumes the root file system space. Isn't it enough?
And for the current change in 1.15, we just need to fix the gap comparing to the previous releases, for any new functionalities, we can add post 1.15.
So we can keep this discussion rolling but we will not include changes into this PR.
There was a problem hiding this comment.
There was a problem hiding this comment.
Yes, that is what I meant root file system of the pod. We don't need to let users config it, instead, we let users to config the cacheLimit which consumes the most proportion of the root file system space.
There was a problem hiding this comment.
@shubham-pampattiwar Does the above comment answer your question? Or do you have more comments? Once you complete the review, please help to approve it.
There was a problem hiding this comment.
looks good, Ack!
| } | ||
|
|
||
| type PodResources struct { | ||
| CPURequest string `json:"cpuRequest,omitempty"` |
There was a problem hiding this comment.
looks good, Ack!
Signed-off-by: Lyndon-Li <[email protected]>
Fix issue #8134, allow to config resource request/limit for data mover micro service pods