Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restic backup and restore progress proposal #1765

Merged
merged 9 commits into from
Aug 22, 2019
Merged

restic backup and restore progress proposal #1765

merged 9 commits into from
Aug 22, 2019

Conversation

prydonius
Copy link
Contributor

Signed-off-by: Adnan Abdulhussein [email protected]

@prydonius prydonius requested review from carlisia, nrb and skriss August 15, 2019 00:07
@carlisia
Copy link
Contributor

This design seems straight forward. As for the question about if a directory being restore into not being empty, I think we need to decide in general, if we need to make a choice, if we want to be more uniform with restic features, or with velero features, or if it's a case-by-case decision.

@prydonius
Copy link
Contributor Author

Agreed, I think we can discuss that as part of #1764. I am feeling more inclined to go for the slightly alternative approach here where we only compare sizes of files that we know are in the backup, that way we don't need to assume that the volume will always be empty for now.

Adnan Abdulhussein added 2 commits August 15, 2019 14:17
update approach to lookup based on files rather than total size
6d67581 
Signed-off-by: Adnan Abdulhussein <[email protected]>
typo
559d62a 
Signed-off-by: Adnan Abdulhussein <[email protected]>
@prydonius
Copy link
Contributor Author

Okay updated this proposal to use the approach where we only consider the list of files in the backup.

@prydonius prydonius marked this pull request as ready for review August 15, 2019 21:24
@nrb nrb added the Area/Design Design Documents label Aug 16, 2019
skriss
skriss reviewed Aug 19, 2019
View reviewed changes
Adnan Abdulhussein added 3 commits August 19, 2019 17:46
record TotalBytes and BytesDone in PodVolumeBackup/Restore and calcul…
272ea25 
…ate percentage in UI

Signed-off-by: Adnan Abdulhussein <[email protected]>
update to go with restic stats approach for restore
5cb96b5 
Signed-off-by: Adnan Abdulhussein <[email protected]>
typo
c88b00e 
Signed-off-by: Adnan Abdulhussein <[email protected]>
skriss
skriss reviewed Aug 21, 2019
View reviewed changes
Copy link
Contributor

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple more small comments but otherwise LGTM!

nrb
nrb reviewed Aug 21, 2019
View reviewed changes
Copy link
Contributor

@nrb nrb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good, I just have a few questions to help my understanding.

Adnan Abdulhussein added 2 commits August 21, 2019 13:23
update high-level design for restic stats
e5ee720 
Signed-off-by: Adnan Abdulhussein <[email protected]>
wait for bytes_done
1531bad 
Signed-off-by: Adnan Abdulhussein <[email protected]>
skriss
skriss approved these changes Aug 21, 2019
View reviewed changes
Copy link
Contributor

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's get one more approval then update status and merge.

carlisia
carlisia reviewed Aug 21, 2019
View reviewed changes
Copy link
Contributor

@carlisia carlisia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just need to change from Draft to Accepted.

change status to accepted
e9c70bd 
Signed-off-by: Adnan Abdulhussein <[email protected]>
@skriss skriss merged commit 86408bf into vmware-tanzu:master Aug 22, 2019
@prydonius prydonius deleted the 1749-proposal branch August 22, 2019 20:20
jessestuart added a commit to jessestuart/velero that referenced this pull request Aug 28, 2019
@jessestuart
Merge remote-tracking branch 'upstream/master' into jesse/20190828_merge
36a4fa4 
* upstream/master: (118 commits)
  restore: rename PV when remapping a namespace if PV exists in-cluster (vmware-tanzu#1779)
  when backing up PVCs with restic, explicitly specify --parent (vmware-tanzu#1807)
  Unit tests for restic restore (vmware-tanzu#1747)
  Upgrade kubernetes dependencies to 1.15.3 (vmware-tanzu#1808)
  create backups from schedules using velero create backup (vmware-tanzu#1734)
  remove calls to restic check before/after prune (vmware-tanzu#1794)
  Propose adding feature flags to velero
  restic backup and restore progress proposal (vmware-tanzu#1765)
  allow custom restic repo prefix to be specified in BSL config
  error if restic repo identifier can't be determined
  update nokogiri dep for website
  update links on website home page for latest release (vmware-tanzu#1789)
  Velero 1.1 blog post
  v1.1.0 changelog
  fix error formatting
  Revert "allow self signed certs with insecureSkipVerify (vmware-tanzu#1769)"
  allow self signed certs with insecureSkipVerify (vmware-tanzu#1769)
  v1.1.0 docs
  Add the prefix to BSL config map so that object stores can use it when initializing (vmware-tanzu#1767)
  add stable/velero to helm commands
  ...
jessestuart added a commit to jessestuart/velero that referenced this pull request Aug 28, 2019
@jessestuart
Merge remote-tracking branch 'upstream/master' into jesse/20190828_merge
9cde4ba 
* upstream/master: (118 commits)
  restore: rename PV when remapping a namespace if PV exists in-cluster (vmware-tanzu#1779)
  when backing up PVCs with restic, explicitly specify --parent (vmware-tanzu#1807)
  Unit tests for restic restore (vmware-tanzu#1747)
  Upgrade kubernetes dependencies to 1.15.3 (vmware-tanzu#1808)
  create backups from schedules using velero create backup (vmware-tanzu#1734)
  remove calls to restic check before/after prune (vmware-tanzu#1794)
  Propose adding feature flags to velero
  restic backup and restore progress proposal (vmware-tanzu#1765)
  allow custom restic repo prefix to be specified in BSL config
  error if restic repo identifier can't be determined
  update nokogiri dep for website
  update links on website home page for latest release (vmware-tanzu#1789)
  Velero 1.1 blog post
  v1.1.0 changelog
  fix error formatting
  Revert "allow self signed certs with insecureSkipVerify (vmware-tanzu#1769)"
  allow self signed certs with insecureSkipVerify (vmware-tanzu#1769)
  v1.1.0 docs
  Add the prefix to BSL config map so that object stores can use it when initializing (vmware-tanzu#1767)
  add stable/velero to helm commands
  ...
jessestuart added a commit to jessestuart/velero that referenced this pull request Aug 28, 2019
@jessestuart
Merge remote-tracking branch 'upstream/master' into jesse/20190828_merge
bebc2df 
* upstream/master: (118 commits)
  restore: rename PV when remapping a namespace if PV exists in-cluster (vmware-tanzu#1779)
  when backing up PVCs with restic, explicitly specify --parent (vmware-tanzu#1807)
  Unit tests for restic restore (vmware-tanzu#1747)
  Upgrade kubernetes dependencies to 1.15.3 (vmware-tanzu#1808)
  create backups from schedules using velero create backup (vmware-tanzu#1734)
  remove calls to restic check before/after prune (vmware-tanzu#1794)
  Propose adding feature flags to velero
  restic backup and restore progress proposal (vmware-tanzu#1765)
  allow custom restic repo prefix to be specified in BSL config
  error if restic repo identifier can't be determined
  update nokogiri dep for website
  update links on website home page for latest release (vmware-tanzu#1789)
  Velero 1.1 blog post
  v1.1.0 changelog
  fix error formatting
  Revert "allow self signed certs with insecureSkipVerify (vmware-tanzu#1769)"
  allow self signed certs with insecureSkipVerify (vmware-tanzu#1769)
  v1.1.0 docs
  Add the prefix to BSL config map so that object stores can use it when initializing (vmware-tanzu#1767)
  add stable/velero to helm commands
  ...
jessestuart added a commit to jessestuart/velero that referenced this pull request Aug 28, 2019
@jessestuart
Merge branch 'jesse/20190828_merge'
fbb3d26 
* jesse/20190828_merge: (511 commits)
  fix(ci): Update arm32 target.
  feat(ci): Auto-build restic-restore-helper image in CI.
  restore: rename PV when remapping a namespace if PV exists in-cluster (vmware-tanzu#1779)
  when backing up PVCs with restic, explicitly specify --parent (vmware-tanzu#1807)
  Unit tests for restic restore (vmware-tanzu#1747)
  Upgrade kubernetes dependencies to 1.15.3 (vmware-tanzu#1808)
  create backups from schedules using velero create backup (vmware-tanzu#1734)
  remove calls to restic check before/after prune (vmware-tanzu#1794)
  Propose adding feature flags to velero
  restic backup and restore progress proposal (vmware-tanzu#1765)
  allow custom restic repo prefix to be specified in BSL config
  error if restic repo identifier can't be determined
  update nokogiri dep for website
  update links on website home page for latest release (vmware-tanzu#1789)
  Velero 1.1 blog post
  v1.1.0 changelog
  fix error formatting
  Revert "allow self signed certs with insecureSkipVerify (vmware-tanzu#1769)"
  allow self signed certs with insecureSkipVerify (vmware-tanzu#1769)
  v1.1.0 docs
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlisia carlisia carlisia left review comments

@nrb nrb nrb left review comments

@skriss skriss skriss approved these changes

Assignees
No one assigned
Labels
Area/Design Design Documents
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@prydonius @carlisia @nrb @skriss