Support a separate URL base for pre-signed URLs #1006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skriss
reviewed
Nov 8, 2018
There was a problem hiding this comment.
Code LGTM. Let's document this here: https://github.com/heptio/ark/blob/master/docs/api-types/backupstoragelocation.md
|
Working on docs |
This allows the Ark server to use one URL for the majority of communications with S3 (or compatible) object storage, and a different URL base for pre-signed URLs (for streaming logs, etc. to clients). Signed-off-by: Andy Goldstein <[email protected]>
ncdc
force-pushed
the
add-s3-public-url
branch
from
b80f29a to
9ae861c
Compare
|
Initial docs edits done |
|
LGTM |
|
@wwitzel3 PTAL |
wwitzel3
approved these changes
Nov 8, 2018
|
I'd recommend testing with s3 (no urls) and minio (just s3Url, s3Url + publicUrl) |
|
@wwitzel3 and I tested and this looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the Ark server to use one URL for the majority of
communications with S3 (or compatible) object storage, and a different
URL base for pre-signed URLs (for streaming logs, etc. to clients).
Signed-off-by: Andy Goldstein [email protected]