Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volume snapshots don't include informative metadata #278

Closed
totemcaf opened this issue Jan 8, 2018 · 4 comments · Fixed by #341
Closed

Volume snapshots don't include informative metadata #278

totemcaf opened this issue Jan 8, 2018 · 4 comments · Fixed by #341
Assignees
Milestone

Comments

@totemcaf
Copy link

totemcaf commented Jan 8, 2018

Currently when a Snapshot is created in AWS due to a Backup, the snapshot has no name nor description. It has only a label pointing to Ark: "tag-key=ark-snapshot"

Having lots of snapshots will be difficult to see why some snapshot is for.

The idea is to add a name, and a description adding more data, for example the Backup name and/or the POD's name owning the PVC. Additional tags can also be added.

@ncdc
Copy link
Contributor

ncdc commented Jan 8, 2018

@skriss let's incorporate this into the backup target design

@ncdc ncdc changed the title Backup Snapshots documented Volume snapshots don't include informative metadata Jan 12, 2018
@activeshadow
Copy link

It would also be great if Ark could capture any existing tags on AWS volumes. Here's why:

When Kubernetes creates volumes in AWS (and probably other cloud providers too) for backing PVs, it adds multiple tags to the volumes (KubernetesCluster, Name, kubernetes.io/created-for/pv/name, kubernetes.io/created-for/pvc/name, etc). When an AWS cluster is managed by kops, the IAM policy assigned to the Kubernetes master(s) relevant to mounting volumes to nodes includes a condition for the KubernetesCluster resource tag. If the tag doesn't exist, then the pods using the PVCs cannot start since the Kubernetes master(s) cannot mount the volumes to the nodes.

One scenario that will have to be addressed is when Ark is being used to migrate PVs from one cluster to another (ie. when the KubernetesCluster tag value will need to be different).

@ftoresan
Copy link

I'm facing the same issue with kops managed clusters.

Would this be a good case for the use of plugins?
Or the change must be done in the EBS backup/restore code?

@ncdc
Copy link
Contributor

ncdc commented Feb 22, 2018

@ftoresan this has to be done in the core Ark server code, possibly with some adjustments to some of the cloud plugin code.

@ncdc ncdc added this to the v0.8.0 milestone Mar 9, 2018
@ncdc ncdc closed this as completed in #341 Mar 14, 2018
kaovilai pushed a commit to kaovilai/velero that referenced this issue Aug 11, 2023
* remove vsc for datamover case

* Move datamover deletion logic to datamover pkg

* run make update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants