Sign the RPM package before moving it #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the hack/rpm/build_package.sh script can get called more than
once to build first a `tanzu-cli` package and then a `tanzu-cli-centos9`
package, we ended up on the second call with a `${PKG_DIR}/` directory
containing multiple packages.
Then, when signing everything in that directory using a `*`, we ended
up only signing the first package that was passed as an argument to the
signer. This caused the `tanzu-cli-centos9` package not to get signed
because it comes alphabetically after `tanzu-cli` when the `*` is
expanded.
To solve this and still benefit from using the `*` which allows to avoid
explicitly dealing with the `-unstable` and/or `-centos` suffixes we
sign the package before we move it to the common `${PKG_DIR}/` directory.
Signed-off-by: Marc Khouzam <[email protected]>
anujc25
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Because the
hack/rpm/build_package.shscript can get called more than once to build first atanzu-clipackage an then atanzu-cli-centos9package, we ended up on the second call with a${PKG_DIR}/directory containing multiple packages.Then, when signing everything in that directory using a
*, we ended up only signing the first package that was passed as an argument to the signer. This caused thetanzu-cli-centos9package not to get signed because it comes alphabetically aftertanzu-cliwhen the*is expanded.To solve this and still benefit from using the
*which allows to avoid explicitly dealing with the-unstableand/or-centossuffixes we sign the package before we move it to the common${PKG_DIR}/directory.Which issue(s) this PR fixes
Fixes # N/A
Describe testing done for PR
Before this PR:
I ran the same test but using a pre-release version
1.6.0-rc.0to show that this one worked by simple luck because alphabetical ordering:With this PR:
I ran the same test but using a pre-release version
1.6.0-rc.0:Release note
Additional information
Special notes for your reviewer