Add provision to update the CSP issuer to TCSP #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prkalle
force-pushed
the
feat/tcsp_issuer
branch
2 times, most recently
from
4b65a11 to
ff3fc60
Compare
anujc25
reviewed
Jul 16, 2024
| } | ||
| // if all the contexts are updated successfully, update the flag in the data store | ||
| if updateSuccess { | ||
| _ = datastore.SetDataStoreValue(isCLIContextsUpdatedToTCSPIssuers, &updateSuccess) |
There was a problem hiding this comment.
Should we show a log message to the user that all the contexts have been migrated to TCSP and tokens have been invalidated? That way, users might not be surprised when the interactive login happens again and it points to a new location.
There was a problem hiding this comment.
Good point. Adding the log is useful to inform user about the changes. I updated the PR with the new log message as shown below. Thanks
The CLI contexts have been updated to use the Tanzu CSP issuer. Any existing tokens obtained through interactive login are now invalid and CLI will automatically obtain a new token through interactive login using the new Tanzu CSP issuer
ff3fc60 to
002ea08
Compare
- Add provision through central configuration to update the CSP issuer from VCSP to TCSP. Also added an option in central configuration so that CLI can react to the configuration flag set in central configuration to update the issuers in the already created contexts. Signed-off-by: Prem Kumar Kalle <[email protected]>
prkalle
force-pushed
the
feat/tcsp_issuer
branch
from
002ea08 to
543c695
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This PR adds provision to update the CSP issuer to TCSP
Summary of changes:
Which issue(s) this PR fixes
Fixes #
Describe testing done for PR
API_TOKEN testing:
$HOME/.config/tanzu/.data-store.yamlfile doesn't the entryisCLIContextsUpdatedToTCSPIssuers: true. (This would be set once we set thecli.core.tanzu_cli_config_csp_issuer_update_flag: trueon a cutover date to update the current CLI contexts created using the old CLI version or current CLI version using the VCSP Issuer. If we set the update the flag to true the contexts issuers would be updated to TCSP.)Now set the
cli.core.tanzu_cli_config_csp_issuer_update_flag: truein the central config file~/.cache/tanzu/plugin_inventory/default/central_config.yamland run any command and verify the context is updated with TCSP issuer.Interactive login test
~/.config/tanzu/.data-store.yamltoisCLIContextsUpdatedToTCSPIssuers: falseTAP pre-integrationorganization using interactive login as shown belowTANZU_CLI_USE_TANZU_CLOUD_SERVICE_PROVIDERand verify both contexts works.Verified the refresh tokens are obtained from the respective issuers (issuer stored in CLI contexts) for both contexts.(You can do that by modifying the expiration time to past time frame so that CLI would automatically refresh it.
Now verify that by updating the central config to update the CLI contexts to new Issuer, the
TAP_pre-integration-staging-d03c5c97context created using VCSP would be updated to new Issuer(and existing tokens are invalidated) and when we try to access the UCP plugin list it should trigger the Interactive login and fetch the access token from the new issuer. (Please setcli.core.tanzu_cli_config_csp_issuer_update_flag: truein "~/.cache/tanzu/plugin_inventory/default/central_config.yaml" so that CLI would update the issuer to new issuer URL and deactivate the interactive login tokens )Release note
Additional information
Special notes for your reviewer