-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respect command mapping for help from plugins #777
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch, and fix!
I suggest we add a test case or two to exercise the tanzu help
functionality if possible.
Signed-off-by: Marc Khouzam <[email protected]>
8d31df3
to
d258820
Compare
I've added a couple of tests that fail before this change and pass after. |
}, | ||
}, | ||
args: []string{"help", "dummy"}, | ||
// Output for the show-invoke-context command which prints the passed arguments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
What this PR does / why we need it
When remapping plugin commands, the
tanzu help
command on those remapped commands is not correct.For example
Which issue(s) this PR fixes
Fixes # N/A
Describe testing done for PR
After the PR:
Notice that the invocation form is respected:
Release note
Additional information
Special notes for your reviewer