Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include a new cosign public key to verify the images #761

Merged
merged 1 commit into from
May 3, 2024

Conversation

anujc25
Copy link
Contributor

@anujc25 anujc25 commented May 3, 2024

What this PR does / why we need it

  • Include a new cosign public key to verify the images

Which issue(s) this PR fixes

Fixes #

Describe testing done for PR

# Clean cache to force plugin inventory image to be downloaded along with signature verification
$ rm -rf ~/.cache/tanzu/plugin_inventory

------------

$ tz plugin search
Some initialization of the CLI is required.
Let's set things up for you.  This will just take a few seconds.

[i] Refreshing plugin inventory cache for "projects.packages.broadcom.com/tanzu_cli/plugins/plugin-inventory:latest", this will take a few seconds.
[i] Reading plugin inventory for "projects.packages.broadcom.com/tanzu_cli/plugins/plugin-inventory:latest", this will take a few seconds.

Initialization done!
==
[i] Refreshing plugin inventory cache for "harbor-repo.vmware.com/tanzu_cli_stage/plugins/plugin-inventory:latest", this will take a few seconds.
[i] Reading plugin inventory for "harbor-repo.vmware.com/tanzu_cli_stage/plugins/plugin-inventory:latest", this will take a few seconds.
  NAME                  DESCRIPTION                                                                       TARGET           LATEST
  accelerator           Manage accelerators in a Kubernetes cluster                                       kubernetes       v1.9.0
  account               TMC account management for the organization                                       mission-control  v0.3.3
  ...

Release note

Include a new cosign public key to verify the images

Additional information

Special notes for your reviewer

@anujc25 anujc25 requested a review from a team as a code owner May 3, 2024 16:45
Copy link
Contributor

@prkalle prkalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@marckhouzam marckhouzam added this to the v1.3.0 milestone May 3, 2024
@anujc25 anujc25 merged commit 2d80149 into vmware-tanzu:main May 3, 2024
8 checks passed
Copy link
Contributor

@marckhouzam marckhouzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Late but still LGTM

vuil pushed a commit to vuil/tanzu-cli that referenced this pull request May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants