Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not prompt for user confirmation to delete context if not exists #705

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

warango4
Copy link
Contributor

What this PR does / why we need it

When user wants to delete a non-existing context, they would first be prompted about deleting the context and then they'd see the error pointing the context does not exist.

This MR intends to improve the user experience and not be prompted to any survey if the context does not exist in the firs place.

Which issue(s) this PR fixes

N/A

Describe testing done for PR

  • Updated unit testing
  • Built and executed locally and tried to delete non-existing context.
image

Additional information

Special notes for your reviewer

@warango4 warango4 requested a review from a team as a code owner March 15, 2024 19:54
Copy link
Contributor

@prkalle prkalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Copy link
Contributor

@anujc25 anujc25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@anujc25 anujc25 merged commit 82324c3 into vmware-tanzu:main Mar 15, 2024
8 checks passed
@warango4 warango4 deleted the tanzucli-499 branch March 15, 2024 22:08
@marckhouzam marckhouzam added this to the v1.3.0 milestone Mar 16, 2024
vuil pushed a commit to vuil/tanzu-cli that referenced this pull request Mar 28, 2024
vuil pushed a commit that referenced this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants