Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude test/e2e/framework tags from cli build #598

Merged
merged 1 commit into from
Nov 18, 2023
Merged

Exclude test/e2e/framework tags from cli build #598

merged 1 commit into from
Nov 18, 2023

Conversation

mpanchajanya
Copy link
Contributor

@mpanchajanya mpanchajanya commented Nov 16, 2023 •
edited
Loading

What this PR does / why we need it

  • Fix the build tag from picking up test/e2e/framework tags

Which issue(s) this PR fixes

Fixes #

Describe testing done for PR

Before the fix

mpanchajanya@mpanchajanF09MK ~/v/r/tanzu-cli (exclude-test-tags)> git describe
test/e2e/framework/v0.0.2
mpanchajanya@mpanchajanF09MK ~/v/r/tanzu-cli (exclude-test-tags)> make build
build darwin-arm64 CLI with version: test/e2e/framework/v0.0.2
mkdir -p bin
cp /Users/mpanchajanya/vmw/repository/tanzu-cli/artifacts/darwin/arm64/cli/core/test/e2e/framework/v0.0.2/tanzu-cli-darwin_arm64 ./bin/tanzu

After the fix

mpanchajanya@mpanchajanF09MK ~/v/r/tanzu-cli (exclude-test-tags)> git describe
test/e2e/framework/v0.0.2
mpanchajanya@mpanchajanF09MK ~/v/r/tanzu-cli (exclude-test-tags)> make build
build darwin-arm64 CLI with version: v1.2.0-dev
mkdir -p bin
cp /Users/mpanchajanya/vmw/repository/tanzu-cli/artifacts/darwin/arm64/cli/core/v1.2.0-dev/tanzu-cli-darwin_arm64 ./bin/tanzu

Release note

Excluded test/e2e/framework tags from CLI and plugin builds

Additional information

Special notes for your reviewer

@mpanchajanya mpanchajanya self-assigned this Nov 16, 2023
@mpanchajanya mpanchajanya marked this pull request as ready for review November 16, 2023 03:53
@mpanchajanya mpanchajanya requested a review from a team as a code owner November 16, 2023 03:53
vuil
vuil reviewed Nov 17, 2023
View reviewed changes
cmd/plugin/builder/template/plugintemplates/plugin-tooling.mk.tmpl Outdated
@@ -10,9 +10,9 @@ ifeq ($(GOHOSTOS),windows)
endif

# Build and version information
PLUGIN_BUILD_SHA ?= $(shell git describe --match=$(git rev-parse --short HEAD) --always --dirty)
PLUGIN_BUILD_SHA ?= $(shell git describe --match=$(git rev-parse --short HEAD) --exclude "test/e2e/framework/*" --always --dirty)
Copy link
Contributor

@vuil vuil Nov 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary? Unless I am missing something. This would mean having some opinions of the repo tags in the author's repo.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vuil makes sense, reverted the change for plugin templates

vuil
vuil approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@vuil vuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@mpanchajanya mpanchajanya merged commit e2caa79 into vmware-tanzu:main Nov 18, 2023
@marckhouzam marckhouzam added this to the v1.2.0 milestone Nov 21, 2023
@marckhouzam marckhouzam added the kind/testing Categorizes issue or PR as related to testing label Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vuil vuil vuil approved these changes

@marckhouzam marckhouzam Awaiting requested review from marckhouzam

Assignees

@mpanchajanya mpanchajanya

Labels
kind/testing Categorizes issue or PR as related to testing
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mpanchajanya @vuil @marckhouzam