Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release-1.0] Merge plugin manifest automatically when building individual plugins with the builder plugin #456

Conversation

anujc25
Copy link
Contributor

@anujc25 anujc25 commented Aug 2, 2023

What this PR does / why we need it

Cherrypick: #454

  • Merge plugin manifest automatically when building individual plugins

  • Expose PLUGIN_BUNDLE_OVERWRITE to forcefully overwrite the plugin_manifest in PluginBundle

Which issue(s) this PR fixes

Fixes #

Describe testing done for PR

Release note

Merge `plugin_manifest.yaml` automatically when building individual plugins with the `builder` plugin

Additional information

Special notes for your reviewer

…with the `builder` plugin

* Merge plugin manifest automatically when building individual plugins

* Expose PLUGIN_BUNDLE_OVERWRITE to forcefully overwrite the plugin_manifest in PluginBundle
@anujc25 anujc25 requested a review from a team as a code owner August 2, 2023 19:32
@anujc25 anujc25 changed the title Merge plugin manifest automatically when building individual plugins with the builder plugin [Release-1.0] Merge plugin manifest automatically when building individual plugins with the builder plugin Aug 2, 2023
Copy link
Contributor

@marckhouzam marckhouzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anujc25 anujc25 merged commit 9f1ec7b into vmware-tanzu:release-1.0 Aug 2, 2023
@marckhouzam marckhouzam added this to the v1.0.0 milestone Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants