Ensure errors.json with structured data is parsed #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zubron
approved these changes
Nov 13, 2019
Currently we were handling only the simple case where the errors.json file contains a map of strings. However, there are situations where the json file may contain more structured data which needs handled. Fixes #994 Signed-off-by: John Schnake <[email protected]>
|
I had updated an error message slightly and one test that wasn't on my radar failed. Pushed the fix and waiting for green to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently, we were handling only the simple case where the errors.json
file contains a map of strings. However, there are situations where
the JSON file may contain more structured data that needs to be handled.
Which issue(s) this PR fixes
Fixes #994
Special notes for your reviewer:
Release note: