Sleep forever after systemd logs plugin finishes #971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently sleep for 1h after the logs are gathered but some test runs take multiple hours which leads to this plugin getting restarted and trying to resubmit logs. This causes confusing messages in the logs since the original plugin pod is gone and the only one that exists gets a 409 error from submitting duplicate results. Fixes #970 Signed-off-by: John Schnake <[email protected]>
zubron
approved these changes
Oct 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We currently sleep for 1h after the logs are gathered but some
test runs take multiple hours which leads to this plugin getting
restarted and trying to resubmit logs. This causes confusing messages
in the logs since the original plugin pod is gone and the only one that
exists gets a 409 error from submitting duplicate results.
Which issue(s) this PR fixes
Fixes #970
Special notes for your reviewer:
Easy to test with our new run-from-stdin capability:
Just a client-side change so no image pushing necessary.
Release note: