-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds new blog post regarding customizing the E2E test image #944
Adds new blog post regarding customizing the E2E test image #944
Conversation
Codecov Report
@@ Coverage Diff @@
## master #944 +/- ##
=======================================
Coverage 47.78% 47.78%
=======================================
Files 76 76
Lines 5226 5226
=======================================
Hits 2497 2497
Misses 2573 2573
Partials 156 156 Continue to review full report at Codecov.
|
Fixed a syntax error causing links to not generate properly; ready for final approval/merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor change requested, that's it. Looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a really great blog post, @johnSchnake!
$ export k8sVersion=$(kubectl version -o json|jq .serverVersion.gitVersion -r) | ||
|
||
# Download the existing run script as a starting place and change its mode to be executable. | ||
$ curl https://raw.githubusercontent.com/kubernetes/kubernetes/master/cluster/images/conformance/run_e2e.sh -o run.sh && chmod +x run.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the downloaded script come from the matching Kubernetes version instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The script doesn't change much since it moved upstream; typically just bug fixes and such. I don't think it is a big deal to take the one from master.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's what I guessed but just wanted to check :)
Signed-off-by: John Schnake <[email protected]>
No description provided.