Process all nodes and treat empty status as unknown

pkg/client/results/processing.go

@@ -97,24 +97,31 @@ func aggregateStatus(items ...Item) string {
 		return StatusUnknown
 	}
 
-	unknownFound := false
+	failedFound, unknownFound := false, false
 	for i := range items {
 		// Branches should just aggregate their leaves and return the result.
 		if len(items[i].Items) > 0 {
 			items[i].Status = aggregateStatus(items[i].Items...)
 		}
 
-		// Any failures immediately fail the parent.
-		if items[i].Status == StatusFailed {
-			return StatusFailed
+		// Empty status should be updated to unknown.
+		if items[i].Status == "" {
+			items[i].Status = StatusUnknown
 		}
 
-		if items[i].Status == StatusUnknown {
+		switch items[i].Status {
+		case StatusFailed:
+			failedFound = true
+		case StatusUnknown:
 			unknownFound = true
+		default:
 		}
 	}
 
-	if unknownFound {
+	// Only return once all processing is completed; otherwise other leaves don't get resolved.
+	if failedFound {
+		return StatusFailed
+	} else if unknownFound {
 		return StatusUnknown
 	}
 

pkg/client/results/processing_test.go

@@ -420,6 +420,75 @@ func TestAggregateStatus(t *testing.T) {
 				},
 			},
 			expected: StatusUnknown,
+		}, {
+			desc: "Leaf nodes with empty status get changed to unknown",
+			input: []Item{
+				{
+					Name: "unknown node",
+					Items: []Item{
+						{
+							Name: "first leaf no status",
+						},
+					},
+				},
+			},
+			expectedItems: []Item{
+				{
+					Name:   "unknown node",
+					Status: StatusUnknown,
+					Items: []Item{
+						{
+							Name:   "first leaf no status",
+							Status: StatusUnknown,
+						},
+					},
+				},
+			},
+			expected: StatusUnknown,
+		}, {
+			desc: "Processes all nodes even after seeing first failure",
+			input: []Item{
+				{
+					Name: "DS plugin",
+					Items: []Item{
+						{
+							Name: "node1",
+							Items: []Item{
+								{Name: "foo", Status: StatusFailed},
+							},
+						},
+						{
+							Name: "node2",
+							Items: []Item{
+								{Name: "foo", Status: StatusFailed},
+							},
+						},
+					},
+				},
+			},
+			expectedItems: []Item{
+				{
+					Name:   "DS plugin",
+					Status: StatusFailed,
+					Items: []Item{
+						{
+							Name:   "node1",
+							Status: StatusFailed,
+							Items: []Item{
+								{Name: "foo", Status: StatusFailed},
+							},
+						},
+						{
+							Name:   "node2",
+							Status: StatusFailed,
+							Items: []Item{
+								{Name: "foo", Status: StatusFailed},
+							},
+						},
+					},
+				},
+			},
+			expected: StatusFailed,
 		},
 	}