Updates sonobuoy to always collect data for it's namespace. #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chuckha
reviewed
Nov 16, 2017
| objqry := func() (interface{}, error) { return kubeClient.Discovery().ServerGroups() } | ||
| query := func() (time.Duration, error) { | ||
| return untypedQuery(cfg.OutputDir(), "servergroups.json", objqry) | ||
| for _, resourceKind := range resources { |
There was a problem hiding this comment.
this block looks a lot better.
This helps when diagnosing issues that arise on failed/wedged tests Signed-off-by: Timothy St. Clair <[email protected]>
timothysc
force-pushed
the
heptio-pods
branch
from
37753f0 to
b1b3acb
Compare
|
k, the negative test passed and is executed by passing |
jhamilton1
pushed a commit
to jhamilton1/sonobuoy
that referenced
this pull request
Jun 27, 2018
Updates sonobuoy to always collect data for it's namespace. Signed-off-by: Jesse Hamilton [email protected]
jhamilton1
pushed a commit
to jhamilton1/sonobuoy
that referenced
this pull request
Jun 27, 2018
Updates sonobuoy to always collect data for it's namespace. Signed-off-by: Jesse Hamilton [email protected] Signed-off-by: Jesse Hamilton [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps when diagnosing issues that arise on failed/wedged tests
Fixes: #81
I'm still testing this atm, but comments welcome.