Add a make dev to output a development manifest
#131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothysc
suggested changes
Nov 7, 2017
| }; | ||
|
|
||
| local myconf = conf(opts); | ||
| local sonobuoyPod = |
There was a problem hiding this comment.
Is the open syntax kosher? dangling =
There was a problem hiding this comment.
I found this really confusing at first too. I think it's basically a "let", the pod is defined in the scope of defining sonobuoy.
Makefile
Outdated
|
|
||
| $(DEV_OUTPUT): examples/ksonnet/dev.jsonnet examples/ksonnet/components/*.jsonnet | ||
| $(KUBECFG_CMD) | ||
|
|
There was a problem hiding this comment.
Can probably remove these extra lines
| if opts.debug then " --debug" else "" | ||
| ]), | ||
| ], | ||
| image: "gcr.io/heptio-images/sonobuoy:master", |
There was a problem hiding this comment.
It would be nice if the image:tag was a var at the top
| "/bin/bash", | ||
| "-c", | ||
| std.join("", [ | ||
| "/sonobuoy master --no-exit=true -v 3 --logtostderr", |
| pod.mixin.spec.volumes(conf.volumes); | ||
| pod.mixin.spec.volumes(myconf.volumes); | ||
|
|
||
| local sonobuoyService = |
| local configmaps = import "examples/ksonnet/components/10-configmaps.jsonnet"; | ||
| local pod = import "examples/ksonnet/components/20-pod.jsonnet"; | ||
|
|
||
| rbac + configmaps + pod.objects(pullPolicy="IfNotPresent", debug=true) |
There was a problem hiding this comment.
Can't we pass a var in from Make targets vs. default?
There was a problem hiding this comment.
I did it this way because I don't like the idea of storing configuration in our Makefile.
liztio
force-pushed
the
liz-make-dev
branch
2 times, most recently
from
24ea0ac to
1863332
Compare
timothysc
approved these changes
Nov 7, 2017
Refactor 20-pod.jsonnet to take a few parameters Signed-off-by: liz <[email protected]>
jhamilton1
pushed a commit
to jhamilton1/sonobuoy
that referenced
this pull request
Jun 27, 2018
Refactor 20-pod.jsonnet to take a few parameters Signed-off-by: liz <[email protected]> Signed-off-by: Jesse Hamilton [email protected]
jhamilton1
pushed a commit
to jhamilton1/sonobuoy
that referenced
this pull request
Jun 27, 2018
Refactor 20-pod.jsonnet to take a few parameters Signed-off-by: liz <[email protected]> Signed-off-by: Jesse Hamilton [email protected] Signed-off-by: Jesse Hamilton [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor 20-pod.jsonnet to take a few parameters
Closes #107
Signed-off-by: liz [email protected]