Don't use x509 common names #1246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use Subject Alternate Names fields instead. Fixes: #1227 Signed-off-by: John Schnake <[email protected]>
|
FYI I just tried to remove the circleci integeation since I moved us to github actions; thats the only test failing. |
|
I don't have a great understanding of the spec but just tried to swap out which field we used. Seems to be sufficient? I am only surprised since it worked on my first try :) |
|
lol i recently did this and didn't even realize this is the fix we need in Sonobuoy 😆 thanks John! |
wilsonehusin
approved these changes
May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Subject Alternate Names fields instead.
Fixes: #1227
Signed-off-by: John Schnake [email protected]