Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove alias for aggregator command #1137

Merged
merged 1 commit into from
Jul 2, 2020

Conversation

zubron
Copy link
Contributor

@zubron zubron commented Jul 2, 2020

What this PR does / why we need it:
We renamed the master command to aggregator in #847 (released in
v0.15.3) but left the previous command there as an alias. Given that we
have had 3 minor releases since this and have phased out all use, we
can remove this alias.

Also rename the file to match the new command name.

Signed-off-by: Bridget McErlean [email protected]

Release note:

Removed the "master" alias from the aggregator command.

We renamed the `master` command to `aggregator` in v0.15.3 but left the
previous command there as an alias. Given that we have had 3 minor
releases since this, we can remove this alias as it is no longer in use.

Also rename the file to match the new command name.

Signed-off-by: Bridget McErlean <[email protected]>
@zubron zubron merged commit e43cefe into vmware-tanzu:master Jul 2, 2020
@zubron zubron deleted the remove-master-alias branch July 2, 2020 15:29
zubron added a commit to zubron/sonobuoy that referenced this pull request Jul 9, 2020
The `master` alias for the `aggregator` command was removed in vmware-tanzu#1137,
however this alias was still in use in the Windows Dockerfile. Replace
the use of this with the new command name `aggregator`.

Signed-off-by: Bridget McErlean <[email protected]>
zubron added a commit that referenced this pull request Jul 9, 2020
The `master` alias for the `aggregator` command was removed in #1137,
however this alias was still in use in the Windows Dockerfile. Replace
the use of this with the new command name `aggregator`.

Signed-off-by: Bridget McErlean <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant