Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sonobuoy 0.20.0 is missing required conformance tests #1212

Closed
adamwg opened this issue Feb 12, 2021 · 4 comments
Closed

Sonobuoy 0.20.0 is missing required conformance tests #1212

adamwg opened this issue Feb 12, 2021 · 4 comments

Comments

@adamwg
Copy link

adamwg commented Feb 12, 2021

What steps did you take and what happened:

We ran 1.20 conformance via Sonobuoy 0.20.0 and submitted the results to k8s-conformance here. The conformance bot flagged a missing required test, and it was determined that the test hadn't run due to a missing metadata update in k/k.

What did you expect to happen:

All required conformance tests for 1.20 to run.

Anything else you would like to add:

I'm not super clear on what's required to fix this. I suspect sonobuoy needs to be re-built (and a new release cut) with the updated test metadata, but the tool is relatively opaque to me, so please let me know if all I need to do is re-run.

Environment:

  • Sonobuoy version: 0.20.0
  • Kubernetes version: (use kubectl version): 1.20.2
  • Kubernetes installer & version:
  • Cloud provider or hardware configuration: DigitalOcean Kubernetes
  • OS (e.g. from /etc/os-release):
  • Sonobuoy tarball (which contains * below)
@wilsonehusin
Copy link
Contributor

@adamwg thanks for filing the report! Looks like this is an integration problem from upstream k/k which should have been fixed by now. I would recommend trying it again.

Sonobuoy doesn't compile the conformance test suite, we simply orchestrate the flow of conformance image published upstream (k8s.gcr.io/conformance:<version>). If this issue has been fixed upstream then I would expect things to pass, or at least $ sonobuoy status returns success.

Let me know if it's still failing though, since the issue is still fresh upstream there might still be moving parts.

@brtkwr
Copy link

brtkwr commented Feb 12, 2021

The k8s.gcr.io/conformance:v0.20.2 image hasnt been updated in 4 weeks so I doubt the recent merge will be reflected there. Maybe we'll need to wait for v1.20.3 to be released??

@wilsonehusin
Copy link
Contributor

not really -- the version tag on k8s.gcr.io/conformance image maps to your cluster version, so if your cluster is 1.20.2, then it will pull the 1.20.2 image.

correct me if I'm wrong, but my understanding is that the failure at the moment is about CNCF integration checker bot, not conformance test suite itself -- so running sonobuoy status should still pass on a conformant cluster.

@adamwg
Copy link
Author

adamwg commented Feb 16, 2021

Thanks for taking a look @wilsonehusin and @brtknr! From previous discussion on cncf/k8s-conformance#1308 it sounded like a sonobuoy update would be needed, but indeed it appears this was just a problem with the conformance checking bot, which is now resolved.

@adamwg adamwg closed this as completed Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants