-
Notifications
You must be signed in to change notification settings - Fork 936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conformance results for v1.20/digitalocean #1308
Conversation
This conformance request is not yet verifiable. Please ensure that PR Title refernces the Kubernetes Release and that the supplied logs refer to the specified Release |
vendor: DigitalOcean name: DigitalOcean Kubernetes version: v1.20.2-do.0 website_url: https://www.digitalocean.com/products/kubernetes/ documentation_url: https://www.digitalocean.com/docs/kubernetes/ product_logo_url: https://assets.digitalocean.com/logos/DO_Logo_vertical_blue.svg type: hosted description: 'DigitalOcean Kubernetes is designed for developers who want a simple and cost effective way to deploy container workloads to a managed Kubernetes service.' Signed-off-by: Adam Wolfe Gordon <[email protected]>
Found v1.20 in logs |
Automatically verified as having all required tests present and passed |
Automatically verified as having all required tests present and passed |
This conformance request failed to include all of the required tests for v1.20 |
The first test found to be mssing was [sig-scheduling] SchedulerPredicates [Serial] validates that there is no conflict between pods with same hostPort but different hostIP and protocol [LinuxOnly] [Conformance] |
Not sure what to make of the bot output here... did the list of required tests change between yesterday and today? |
@adamwg I looked at the failure message and replicated it in another repo. The error is valid and there is a miss-match between the conformance.yaml file in the K/K Master branch and the content of your junit file. This was caused by PR #98299 changing the conformance.yaml file. Your data contain the test [sig-scheduling] SchedulerPredicates [Serial] validates that there is no conflict between pods with same hostPort but different hostIP and protocol [LinuxOnly] [Conformance] but that was replaced by [sig-network] HostPort validates that there is no conflict between pods with same hostPort but different hostIP and protocol [LinuxOnly] [Conformance] in the PR mentioned. Sorry, for the confusing error message. The message has a logic error, reporting the test that fell out and not the missing new test. (We are working on that) |
@Riaankl Thanks for digging! I'm confused, though - what does the master branch of k/k have to do with this? Since we're certifying conformance for 1.20 here, shouldn't the 1.20 version of conformance.yaml be used? It hasn't been updated since November. |
Same issue here |
@adamwg It seems to be a bug. |
@Riaankl Thanks for the update! Please let me know if there's any action needed from my side. |
@Riaankl I can re-run and submit a new PR. To be clear, though - I'm using sonobuoy per the instructions in this repo, not running tests directly from k/k. Does sonobuoy need an update to pull in the right tests? |
Yes, you will have to update sonobuoy to retrieve the newly merge metadata updates and then run it with that. |
@adamwg I believe we figured out the issue causing the failure of PR checks. |
Found v1.20 in logs |
Automatically verified as having all required tests present and passed |
Automatically verified as having all required tests present and passed |
You are now Certified Kubernetes |
vendor: DigitalOcean name: DigitalOcean Kubernetes version: v1.20.2-do.0 website_url: https://www.digitalocean.com/products/kubernetes/ documentation_url: https://www.digitalocean.com/docs/kubernetes/ product_logo_url: https://assets.digitalocean.com/logos/DO_Logo_vertical_blue.svg type: hosted description: 'DigitalOcean Kubernetes is designed for developers who want a simple and cost effective way to deploy container workloads to a managed Kubernetes service.' Signed-off-by: Adam Wolfe Gordon <[email protected]>
vendor: DigitalOcean name: DigitalOcean Kubernetes version: v1.20.2-do.0 website_url: https://www.digitalocean.com/products/kubernetes/ documentation_url: https://www.digitalocean.com/docs/kubernetes/ product_logo_url: https://assets.digitalocean.com/logos/DO_Logo_vertical_blue.svg type: hosted description: 'DigitalOcean Kubernetes is designed for developers who want a simple and cost effective way to deploy container workloads to a managed Kubernetes service.' Signed-off-by: Adam Wolfe Gordon <[email protected]>
vendor: DigitalOcean name: DigitalOcean Kubernetes version: v1.20.2-do.0 website_url: https://www.digitalocean.com/products/kubernetes/ documentation_url: https://www.digitalocean.com/docs/kubernetes/ product_logo_url: https://assets.digitalocean.com/logos/DO_Logo_vertical_blue.svg type: hosted description: 'DigitalOcean Kubernetes is designed for developers who want a simple and cost effective way to deploy container workloads to a managed Kubernetes service.' Signed-off-by: Adam Wolfe Gordon <[email protected]>
vendor: DigitalOcean name: DigitalOcean Kubernetes version: v1.20.2-do.0 website_url: https://www.digitalocean.com/products/kubernetes/ documentation_url: https://www.digitalocean.com/docs/kubernetes/ product_logo_url: https://assets.digitalocean.com/logos/DO_Logo_vertical_blue.svg type: hosted description: 'DigitalOcean Kubernetes is designed for developers who want a simple and cost effective way to deploy container workloads to a managed Kubernetes service.' Signed-off-by: Adam Wolfe Gordon <[email protected]>
vendor: DigitalOcean
name: DigitalOcean Kubernetes
version: v1.20.2-do.0
website_url: https://www.digitalocean.com/products/kubernetes/
documentation_url: https://www.digitalocean.com/docs/kubernetes/
product_logo_url: https://assets.digitalocean.com/logos/DO_Logo_vertical_blue.svg
type: hosted
description: 'DigitalOcean Kubernetes is designed for developers who want a simple and cost effective way to deploy container workloads to a managed Kubernetes service.'
Signed-off-by: Adam Wolfe Gordon [email protected]
Pre-submission checklist:
Please check each of these after submitting your pull request:
repo_url
?