Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conformance results for v1.20/digitalocean #1308

Merged
merged 1 commit into from
Feb 20, 2021

Conversation

adamwg
Copy link
Contributor

@adamwg adamwg commented Feb 2, 2021

vendor: DigitalOcean
name: DigitalOcean Kubernetes
version: v1.20.2-do.0
website_url: https://www.digitalocean.com/products/kubernetes/
documentation_url: https://www.digitalocean.com/docs/kubernetes/
product_logo_url: https://assets.digitalocean.com/logos/DO_Logo_vertical_blue.svg
type: hosted
description: 'DigitalOcean Kubernetes is designed for developers who want a simple and cost effective way to deploy container workloads to a managed Kubernetes service.'

Signed-off-by: Adam Wolfe Gordon [email protected]

Pre-submission checklist:

Please check each of these after submitting your pull request:

  • If this is a new entry, have you submitted a signed participation form?
  • Did you include the product/project logo in SVG, EPS or AI format?
  • Does your logo clearly state the name of the product/project and follow the other logo guidelines?
  • If your product/project is open source, did you include the repo_url?
  • Did you copy and paste the installation and configuration instructions into the README.md file in addition to linking to them?

@cncf-ci
Copy link
Collaborator

cncf-ci commented Feb 2, 2021

This conformance request is not yet verifiable. Please ensure that PR Title refernces the Kubernetes Release and that the supplied logs refer to the specified Release

@adamwg adamwg changed the title Conformance results for 1.20/digitalocean Conformance results for v1.20/digitalocean Feb 2, 2021
vendor: DigitalOcean
name: DigitalOcean Kubernetes
version: v1.20.2-do.0
website_url: https://www.digitalocean.com/products/kubernetes/
documentation_url: https://www.digitalocean.com/docs/kubernetes/
product_logo_url: https://assets.digitalocean.com/logos/DO_Logo_vertical_blue.svg
type: hosted
description: 'DigitalOcean Kubernetes is designed for developers who want a simple and cost effective way to deploy container workloads to a managed Kubernetes service.'

Signed-off-by: Adam Wolfe Gordon <[email protected]>
@cncf-ci cncf-ci added release-documents-checked All release documents are present and pass all checks release-v1.20 labels Feb 2, 2021
@cncf-ci
Copy link
Collaborator

cncf-ci commented Feb 2, 2021

Found v1.20 in logs

@cncf-ci
Copy link
Collaborator

cncf-ci commented Feb 2, 2021

Automatically verified as having all required tests present and passed

@cncf-ci
Copy link
Collaborator

cncf-ci commented Feb 2, 2021

Automatically verified as having all required tests present and passed

@cncf-ci
Copy link
Collaborator

cncf-ci commented Feb 3, 2021

This conformance request failed to include all of the required tests for v1.20

@cncf-ci
Copy link
Collaborator

cncf-ci commented Feb 3, 2021

The first test found to be mssing was [sig-scheduling] SchedulerPredicates [Serial] validates that there is no conflict between pods with same hostPort but different hostIP and protocol [LinuxOnly] [Conformance]

@adamwg
Copy link
Contributor Author

adamwg commented Feb 3, 2021

Not sure what to make of the bot output here... did the list of required tests change between yesterday and today?

@riaankleinhans
Copy link
Collaborator

@adamwg I looked at the failure message and replicated it in another repo.

The error is valid and there is a miss-match between the conformance.yaml file in the K/K Master branch and the content of your junit file. This was caused by PR #98299 changing the conformance.yaml file.

Your data contain the test [sig-scheduling] SchedulerPredicates [Serial] validates that there is no conflict between pods with same hostPort but different hostIP and protocol [LinuxOnly] [Conformance] but that was replaced by [sig-network] HostPort validates that there is no conflict between pods with same hostPort but different hostIP and protocol [LinuxOnly] [Conformance] in the PR mentioned.
Unfortunately, this will happen if the conformance.yaml get updated between the pulling of the data and the submission of the results.
You can resolve this by pulling the latest data and re-run your tests.

Sorry, for the confusing error message. The message has a logic error, reporting the test that fell out and not the missing new test. (We are working on that)

@adamwg
Copy link
Contributor Author

adamwg commented Feb 8, 2021

@Riaankl Thanks for digging! I'm confused, though - what does the master branch of k/k have to do with this? Since we're certifying conformance for 1.20 here, shouldn't the 1.20 version of conformance.yaml be used? It hasn't been updated since November.

@brtkwr
Copy link
Contributor

brtkwr commented Feb 10, 2021

Same issue here

@riaankleinhans
Copy link
Collaborator

@adamwg It seems to be a bug.
We are trying to sort it out as soon as possible.

@adamwg
Copy link
Contributor Author

adamwg commented Feb 10, 2021

@Riaankl Thanks for the update! Please let me know if there's any action needed from my side.

@riaankleinhans
Copy link
Collaborator

@adamwg the blocking PR has merged and the bug should be fixed now.
Would you please update your k/k repo and submit a new PR for conformance?

@adamwg
Copy link
Contributor Author

adamwg commented Feb 11, 2021

@Riaankl I can re-run and submit a new PR. To be clear, though - I'm using sonobuoy per the instructions in this repo, not running tests directly from k/k. Does sonobuoy need an update to pull in the right tests?

@riaankleinhans
Copy link
Collaborator

Yes, you will have to update sonobuoy to retrieve the newly merge metadata updates and then run it with that.
That should solve it.

@riaankleinhans
Copy link
Collaborator

@adamwg I believe we figured out the issue causing the failure of PR checks.
on 16 Jan, after the release for 1.20 was cut, two commits changed the 1.20 conformance.yaml file.
This cause a mismatch between what you get out of Sonobuoy and that the bot check against the v1.20 .yaml file.
A PR was created to revert these commits, and that should stop the pain we are experiencing.
We will discuss the topic at the next conformance meeting to see how the historical conformance.yaml file should be protected against unwanted change.
Once the PR merge I believe the bot will check are label your PR correcly.

@cncf-ci cncf-ci removed no-failed-tests-v1.20 release-documents-checked All release documents are present and pass all checks labels Feb 15, 2021
@cncf-ci
Copy link
Collaborator

cncf-ci commented Feb 15, 2021

Found v1.20 in logs

@cncf-ci
Copy link
Collaborator

cncf-ci commented Feb 15, 2021

Automatically verified as having all required tests present and passed

@cncf-ci
Copy link
Collaborator

cncf-ci commented Feb 15, 2021

Automatically verified as having all required tests present and passed

@taylorwaggoner
Copy link
Contributor

You are now Certified Kubernetes

@taylorwaggoner taylorwaggoner merged commit 8ee8890 into cncf:master Feb 20, 2021
tnorlin pushed a commit to tnorlin/k8s-conformance that referenced this pull request Dec 6, 2023
vendor: DigitalOcean
name: DigitalOcean Kubernetes
version: v1.20.2-do.0
website_url: https://www.digitalocean.com/products/kubernetes/
documentation_url: https://www.digitalocean.com/docs/kubernetes/
product_logo_url: https://assets.digitalocean.com/logos/DO_Logo_vertical_blue.svg
type: hosted
description: 'DigitalOcean Kubernetes is designed for developers who want a simple and cost effective way to deploy container workloads to a managed Kubernetes service.'

Signed-off-by: Adam Wolfe Gordon <[email protected]>
devidask27 pushed a commit to platform9/k8s-conformance that referenced this pull request Feb 20, 2024
vendor: DigitalOcean
name: DigitalOcean Kubernetes
version: v1.20.2-do.0
website_url: https://www.digitalocean.com/products/kubernetes/
documentation_url: https://www.digitalocean.com/docs/kubernetes/
product_logo_url: https://assets.digitalocean.com/logos/DO_Logo_vertical_blue.svg
type: hosted
description: 'DigitalOcean Kubernetes is designed for developers who want a simple and cost effective way to deploy container workloads to a managed Kubernetes service.'

Signed-off-by: Adam Wolfe Gordon <[email protected]>
tnorlin pushed a commit to tnorlin/k8s-conformance that referenced this pull request Oct 25, 2024
vendor: DigitalOcean
name: DigitalOcean Kubernetes
version: v1.20.2-do.0
website_url: https://www.digitalocean.com/products/kubernetes/
documentation_url: https://www.digitalocean.com/docs/kubernetes/
product_logo_url: https://assets.digitalocean.com/logos/DO_Logo_vertical_blue.svg
type: hosted
description: 'DigitalOcean Kubernetes is designed for developers who want a simple and cost effective way to deploy container workloads to a managed Kubernetes service.'

Signed-off-by: Adam Wolfe Gordon <[email protected]>
tnorlin pushed a commit to tnorlin/k8s-conformance that referenced this pull request Dec 13, 2024
vendor: DigitalOcean
name: DigitalOcean Kubernetes
version: v1.20.2-do.0
website_url: https://www.digitalocean.com/products/kubernetes/
documentation_url: https://www.digitalocean.com/docs/kubernetes/
product_logo_url: https://assets.digitalocean.com/logos/DO_Logo_vertical_blue.svg
type: hosted
description: 'DigitalOcean Kubernetes is designed for developers who want a simple and cost effective way to deploy container workloads to a managed Kubernetes service.'

Signed-off-by: Adam Wolfe Gordon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants