This repository has been archived by the owner on Jun 28, 2023. It is now read-only.
add workflow to test external-dns PRs #2950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on changes to external-dns files the unit tests will be run Signed-off-by: Edwin Xie <[email protected]> Co-authored-by: Aidan Obley <[email protected]>
github-actions
bot
added
the
owner/packages
mcwumbly
previously approved these changes
Jan 27, 2022
There was a problem hiding this comment.
lgtm
I see the tests ran successfully in this PR here: https://github.com/vmware-tanzu/community-edition/runs/4958766271?check_suite_focus=true#step:5:75
jpmcb
reviewed
Jan 27, 2022
Signed-off-by: Christian Ang <[email protected]>
jpmcb
approved these changes
Jan 31, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
On changes to external-dns files the unit tests will be run. This gives more confidence on PRs for external-dns.
The tests were failing to run due to a go.mod issue, so there is an update to the dependencies.
Details for the Release Notes (PLEASE PROVIDE)
Describe testing done for PR
Tested in a fork to verify the workflow behaves correctly.
Special notes for your reviewer