This repository has been archived by the owner on Jun 28, 2023. It is now read-only.
Update release and test scripts to include unmanaged-cluster plugin
#2869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karuppiah Natarajan <[email protected]>
Signed-off-by: Karuppiah Natarajan <[email protected]>
Signed-off-by: Karuppiah Natarajan <[email protected]>
Signed-off-by: Karuppiah Natarajan <[email protected]>
github-actions
bot
added
the
owner/release-eng
joshrosso
suggested changes
Jan 20, 2022
There was a problem hiding this comment.
Noticing on this and main that make package-release fails with:
+ popd
~/d/community-edition
+ for env in ${ENVS}
+ binaryname=windows_amd64
+ extension=
+ [[ windows_amd64 = *windows* ]]
+ extension=.exe
+ scriptextension=.sh
+ [[ windows_amd64 = *windows* ]]
+ scriptextension=.bat
+ PACKAGE_DIR=hack/release/../../build/tce-windows-amd64-v0.10.0-fake.4
+ rm -rf hack/release/../../build/tce-windows-amd64-v0.10.0-fake.4
+ mkdir -p hack/release/../../build/tce-windows-amd64-v0.10.0-fake.4/bin
+ cp -f /tmp/tce-release/tanzu-framework/artifacts/core/v0.10.0/tanzu-core-windows_amd64.exe hack/release/../../build/tce-windows-amd64-v0.10.0-fake.4/bin/tanzu.exe
cp: cannot stat '/tmp/tce-release/tanzu-framework/artifacts/core/v0.10.0/tanzu-core-windows_amd64.exe': No such file or directory
make: *** [Makefile:240: package-release] Error 1
Let me know if there's any need to resolve this it in this PR.
|
I did a |
|
yup, works great for me. sorry about that, must have been my environment! |
joshrosso
approved these changes
Jan 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Updates release and test scripts to include
unmanaged-clusterpluginDetails for the Release Notes (PLEASE PROVIDE)
Which issue(s) this PR fixes
Fixes: #2867
Describe testing done for PR
Tested in my Linux Dev environment and everything looked fine for the Linux build that I tried out. Pipeline of PR is
stuck though, due to #2870passing now 😁Special notes for your reviewer
None