This repository has been archived by the owner on Jun 28, 2023. It is now read-only.
Fork output writer to avoid bold table headers #2841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshrosso
reviewed
Jan 13, 2022
|
stmcginnis
force-pushed
the
unmanaged-outputwriter
branch
2 times, most recently
from
52b7b80 to
d26dc9d
Compare
joshrosso
approved these changes
Jan 13, 2022
|
@stmcginnis would you fix the small merge conflict then self-merge? thanks! |
We had been using the OutputWriter from tanzu-framework. In the release we are using, the header values for table columns in that version would bold the text, resulting in garbage characters when doing things like `watch` to wait for conditions in the output. This has since been fixed, but is not available in a tanzu-framework release we can use yet. Until we are able to bump up to a version of tanzu-framework that has the fix, this temporarily duplicates that code locally. This can be removed in a future release. Signed-off-by: Sean McGinnis <[email protected]>
stmcginnis
force-pushed
the
unmanaged-outputwriter
branch
from
d26dc9d to
5087cfe
Compare
joshrosso
pushed a commit
that referenced
this pull request
Jan 18, 2022
We had been using the OutputWriter from tanzu-framework. In the release we are using, the header values for table columns in that version would bold the text, resulting in garbage characters when doing things like `watch` to wait for conditions in the output. This has since been fixed, but is not available in a tanzu-framework release we can use yet. Until we are able to bump up to a version of tanzu-framework that has the fix, this temporarily duplicates that code locally. This can be removed in a future release. Signed-off-by: Sean McGinnis <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had been using the OutputWriter from tanzu-framework. In the release
we are using, the header values for table columns in that version would
bold the text, resulting in garbage characters when doing things like
watchto wait for conditions in the output. This has since been fixed,but is not available in a tanzu-framework release we can use yet.
Until we are able to bump up to a version of tanzu-framework that has
the fix, this temporarily duplicates that code locally. This can be
removed in a future release.