This repository has been archived by the owner on Jun 28, 2023. It is now read-only.
unmanaged-cluster: add line break after error output #2839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This inserts a line break when an error is returned to the calling client (cmd packag). It improves readability as PS1 of the terminal will not start at the end of the error message. Signed-off-by: joshrosso <[email protected]>
stmcginnis
reviewed
Jan 13, 2022
jpmcb
reviewed
Jan 13, 2022
| @@ -106,7 +106,7 @@ func create(cmd *cobra.Command, args []string) error { | |||
| tm := tanzu.New(log) | |||
| err = tm.Deploy(clusterConfig) | |||
| if err != nil { | |||
| log.Error(err.Error()) | |||
| log.Errorf("%s\n", err.Error()) | |||
There was a problem hiding this comment.
An alternative here would be to change the log.Error method to:
+ fmt.Println(message)
- fmt.Print(message)but I'm also good with your change
There was a problem hiding this comment.
let's revisit this option as an enhancement to the log package.
joshrosso
pushed a commit
that referenced
this pull request
Jan 18, 2022
This inserts a line break when an error is returned to the calling client (cmd packag). It improves readability as PS1 of the terminal will not start at the end of the error message. Signed-off-by: joshrosso <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This inserts a line break when an error is returned to the calling
client (cmd packag). It improves readability as PS1 of the terminal will
not start at the end of the error message.
Describe testing done for PR
Prior to this change, outputs like the following occurred.
With these changes, we now see an appropriate break, improving readability.
Special notes for your reviewer
This is a minor enough change where-in if @jpmcb or @stmcginnis do not have any suggestions, it can be approved and merged.