This repository has been archived by the owner on Jun 28, 2023. It is now read-only.
Add prefix to data hash, so it cannot be parsed as integer. #2694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
owner/packages
HanFa
force-pushed
the
topic/fhan/fix-data-hash
branch
from
212bf2d to
4cb1b54
Compare
|
/lgtm |
lubronzhan
approved these changes
Dec 9, 2021
vijaykatam
approved these changes
Dec 9, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
We observe scenarios that some data value hash, e,g,
5386e49will be treated as an integer by the ytt template. And kubectl cannot apply the rendered yaml file. Submit a fix that prefix "h-" before the hash to enforce it as a string.Details for the Release Notes (PLEASE PROVIDE)
Which issue(s) this PR fixes
Fixes: #
Describe testing done for PR
Unit test of the vsphere-cpi addon.
Special notes for your reviewer