Skip to content
This repository has been archived by the owner on Jun 28, 2023. It is now read-only.

harbor package 2.3.3 support secretName for tlsCertificate #2554

Merged
merged 1 commit into from
Nov 16, 2021

Conversation

zyyw
Copy link
Contributor

@zyyw zyyw commented Nov 16, 2021

Signed-off-by: Shengwen Yu [email protected]

What this PR does / why we need it

This PR is to introduce a new configuration called "secretName" under "tlsCertificate" so that Harbor package 2.3.3
can auto reload ca.crt, tls.crt, tls.key info.

Details for the Release Notes (PLEASE PROVIDE)

Introducing a new configuration called "secretName" under "tlsCertificate" 
in order to auto load ca.crt, tls.crt, tls.key info for Harbor 2.3.3

Which issue(s) this PR fixes

Fixes: #2553

Describe testing done for PR

unit test:
cd addons/packages/harbor/2.3.3/test
make test

functional test:

  • create a secret call "harbor-tls-2" with ca.crt, tls.crt, tls.key and duration (valid for) 1h through openssl tool
  • set "tlsCertificate.secretName" in harbor-data-values.yaml file to be "harbor-tls-2"
  • install Harbor package 2.3.3 with harbor-data-values.yaml
  • login into Harbor portal, check the certificate validation, it's only valid within 1h after it's created
  • using openssl to generate certificate info valid through 2 hours and update secret "harbor-tls"
  • login to Harbor portal, check the certificate validation, it's should be valid within 2 hours after it's created

Special notes for your reviewer

@zyyw zyyw requested a review from a team as a code owner November 16, 2021 18:03
@github-actions github-actions bot added the owner/packages Work executed by a package's maintainer label Nov 16, 2021
@zyyw zyyw force-pushed the topic/yshengwen/secretName branch from be961c2 to 884de87 Compare November 16, 2021 18:05
Copy link
Contributor

@seemiller seemiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seemiller seemiller merged commit f1aa59c into vmware-tanzu:main Nov 16, 2021
@heww
Copy link
Contributor

heww commented Nov 17, 2021

@seemiller Thanks for the review of this PR. I think we miss the description for the new configuration in the valuesSchema of package.yaml in this PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-not-required owner/packages Work executed by a package's maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

auto load ca.crt, tls.crt, tls.key info introducing a new field called "secretName" under "tlsCertificate"
4 participants