This repository has been archived by the owner on Jun 28, 2023. It is now read-only.
Use buildinfo.Version instead of buildVersion when building with tanzu framework v0.10.0
#2523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/cli
owner/release-eng
jpmcb
commented
Nov 11, 2021
jpmcb
force-pushed
the
david-update-frame
branch
from
919914f to
623309d
Compare
jpmcb
changed the title
buildinfo.Version instead of buildVersion when building with tanzu framework v0.10.0buildinfo.Version instead of buildVersion when building with tanzu framework v0.10.0
jpmcb
force-pushed
the
david-update-frame
branch
from
623309d to
7dcff4e
Compare
Replaces using buildVersion ldflag Signed-off-by: John McBride <[email protected]>
jpmcb
force-pushed
the
david-update-frame
branch
from
7dcff4e to
826324a
Compare
davidvonthenen
approved these changes
Nov 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This uses the newer
buildinfo.Versionapi in tanzu framework instead of thecli.buildVersionapi (which has been deprecated vmware-tanzu/tanzu-framework@3162254#diff-287b2c13779f4ba2d8e41cc7c201cb67605ab8ef8cce54a977df7a5c83b00dddR20-R21)Details for the Release Notes (PLEASE PROVIDE)
N/a - This is more to demonstrate using the new API so we can bump our tanzu framework version
Which issue(s) this PR fixes
Related to #2520
Describe testing done for PR
Able to
make install-all-tanzu-cli-pluginsSpecial notes for your reviewer
See note below on the standalone-cluster version