This repository has been archived by the owner on Jun 28, 2023. It is now read-only.
Standalone overhaul: Fixes 1 column emoji in delete command and fixes tty animating problem #2473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replaces "SawEmoji" with "TestTubeEmoji" which is 2 colums - Adds newline to count 0 for tty logging in animating progress Signed-off-by: John McBride <[email protected]>
stmcginnis
approved these changes
Nov 8, 2021
joshrosso
pushed a commit
that referenced
this pull request
Jan 18, 2022
- Replaces "SawEmoji" with "TestTubeEmoji" which is 2 colums - Adds newline to count 0 for tty logging in animating progress Signed-off-by: John McBride <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
I noticed that the 🪚 emoji in the terminal wasn't 2 columns in the delete command leading to some odd spacing. The animate progress logging was also not working for
tty=false:SawEmojiwithTestTubeEmojiwhich is 2 columnsDescribe testing done for PR
Using the test tube emoji in the delete command:
Now, with
tty=false, we get new lines after the logging events in animating events (instead of weird spacing between each line):