This repository has been archived by the owner on Jun 28, 2023. It is now read-only.
Removing kind command dependency for Diagnostics
#2445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladimirvivien
changed the title
kind command dependency for Diagnosticskind command dependency for Diagnostics
vladimirvivien
changed the title
kind command dependency for Diagnosticskind command dependency for Diagnostics
github-actions
bot
added
owner/release-eng
This PR removes dependency on local kind command by replacing all kind command with with equivalent docker commands. The code also uses the kind package to implement some functionlities. Signed-off-by: Vladimir Vivien <[email protected]>
davidvonthenen
approved these changes
Nov 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This PR remove the dependency on the kind command by replacing exec kind commands with equivalent docker command in scripts.
Details for the Release Notes (PLEASE PROVIDE)
Which issue(s) this PR fixes
Fixes: #1950
Describe testing done for PR
Create stand-alone and managed Docker-backed clusters to test
tanzu diagnostics collect