-
Notifications
You must be signed in to change notification settings - Fork 306
Add sriov-network-device-plugin package #2422
Add sriov-network-device-plugin package #2422
Conversation
The |
Ok, let me follow the example to replace the base image. Thanks for the information @seemiller |
50fafe7
to
8dbbf32
Compare
@seemiller Just have one question about image. When the non-alpine image is built, where should I push to? Also projects.registry.vmware.com/tce like local-path-provisioner? Is there a recommendation? |
b0e87d2
to
f9d0855
Compare
Don't mind this comment, pushed to tce/ registry |
82f691d
to
7852e74
Compare
d6adb8e
to
7e86ad9
Compare
Hey @seemiller could you take a look again? |
90f8caf
to
c06b107
Compare
addons/packages/sriov-network-device-plugin/3.3.2/test/README.md
Outdated
Show resolved
Hide resolved
d227a17
to
a710873
Compare
Hi @vmware-tanzu/tce-owners can you take a look at this request again. Thank you. |
4b1760c
to
29bc97e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
addons/packages/sriov-network-device-plugin/3.3.2/bundle/config/helper.lib.yaml
Outdated
Show resolved
Hide resolved
addons/packages/sriov-network-device-plugin/3.3.2/test/README.md
Outdated
Show resolved
Hide resolved
29bc97e
to
6f3e9b2
Compare
URL lint check is failing because of Currently checking 27 url(s) out of 65
Status: Fail
URL: https://github.com/rebuy-de/aws-nuke/releases/download/v2.15.0/aws-nuke-v2.15.0-linux-amd64.tar.gz
Error: http Status-code 502
Total 1 file(s) contain(s) this URL
File Path: test/install-dependencies.sh
URL Position: 91 : 16 |
Signed-off-by: Chen Liu <[email protected]>
7b8fa1a
to
b6fab64
Compare
Signed-off-by: Chen Liu [email protected]
What this PR does / why we need it
Add sriov-network-device-plugin 3.3.2 package as a first step
Details for the Release Notes (PLEASE PROVIDE)
Which issue(s) this PR fixes
Fixes: #2423
Describe testing done for PR
Special notes for your reviewer