Skip to content
This repository has been archived by the owner on Jun 28, 2023. It is now read-only.

Add sriov-network-device-plugin package #2422

Merged

Conversation

chenliu1993
Copy link
Contributor

@chenliu1993 chenliu1993 commented Nov 2, 2021

Signed-off-by: Chen Liu [email protected]

What this PR does / why we need it

Add sriov-network-device-plugin 3.3.2 package as a first step

Details for the Release Notes (PLEASE PROVIDE)

sriov-network-device-plugin3.3.2  is added as a new package.

Which issue(s) this PR fixes

Fixes: #2423

Describe testing done for PR

  1. Template check test pass
  2. Deployed on a workload cluster through package installation and it passed with expected behaviour(deployed on different nodes with labels specified)
sriov-device-plugin-value1         1         1         1       1            1           beta.kubernetes.io/arch=amd64,key=value1   97m
sriov-device-plugin-value2         1         1         1       1            1           beta.kubernetes.io/arch=amd64,key=value2   97m

Special notes for your reviewer

@chenliu1993 chenliu1993 requested a review from wjun November 2, 2021 07:41
@github-actions github-actions bot added owner/docs Work executed by VMware documentation team owner/packages Work executed by a package's maintainer labels Nov 2, 2021
@seemiller
Copy link
Contributor

The imagelint check failed indicating that there is an Alpine image in this package. Unfortunately, due to licensing issues, we cannot accept any packages containing Alpine images. We'll have to build our own distro of this software and package that. This involves writing a Dockerfile and building an image, pushing that to a registry and then packaging that. The local-path-storage package is an example of this. Also, at this time we do not have a detailed step by step guide for how to do this.

@chenliu1993
Copy link
Contributor Author

The imagelint check failed indicating that there is an Alpine image in this package. Unfortunately, due to licensing issues, we cannot accept any packages containing Alpine images. We'll have to build our own distro of this software and package that. This involves writing a Dockerfile and building an image, pushing that to a registry and then packaging that. The local-path-storage package is an example of this. Also, at this time we do not have a detailed step by step guide for how to do this.

Ok, let me follow the example to replace the base image. Thanks for the information @seemiller

@chenliu1993 chenliu1993 force-pushed the chenliu1993/add_sriov_dp_with_test branch from 50fafe7 to 8dbbf32 Compare November 3, 2021 06:52
@chenliu1993
Copy link
Contributor Author

chenliu1993 commented Nov 3, 2021

@seemiller Just have one question about image. When the non-alpine image is built, where should I push to? Also projects.registry.vmware.com/tce like local-path-provisioner? Is there a recommendation?

@chenliu1993 chenliu1993 force-pushed the chenliu1993/add_sriov_dp_with_test branch 2 times, most recently from b0e87d2 to f9d0855 Compare November 4, 2021 08:30
@chenliu1993
Copy link
Contributor Author

@seemiller Just have one question about image. When the non-alpine image is built, where should I push to? Also projects.registry.vmware.com/tce like local-path-provisioner? Is there a recommendation?

Don't mind this comment, pushed to tce/ registry

@chenliu1993 chenliu1993 force-pushed the chenliu1993/add_sriov_dp_with_test branch 3 times, most recently from 82f691d to 7852e74 Compare November 4, 2021 09:20
@chenliu1993 chenliu1993 marked this pull request as ready for review November 4, 2021 09:31
@chenliu1993 chenliu1993 requested a review from a team as a code owner November 4, 2021 09:31
@chenliu1993 chenliu1993 force-pushed the chenliu1993/add_sriov_dp_with_test branch 3 times, most recently from d6adb8e to 7e86ad9 Compare November 8, 2021 07:26
@stmcginnis
Copy link
Contributor

Hey @seemiller could you take a look again?

README.md Show resolved Hide resolved
@chenliu1993 chenliu1993 force-pushed the chenliu1993/add_sriov_dp_with_test branch 4 times, most recently from 90f8caf to c06b107 Compare November 15, 2021 05:05
@chenliu1993 chenliu1993 force-pushed the chenliu1993/add_sriov_dp_with_test branch 3 times, most recently from d227a17 to a710873 Compare November 15, 2021 12:16
@chenliu1993
Copy link
Contributor Author

Hi @vmware-tanzu/tce-owners can you take a look at this request again. Thank you.

@chenliu1993 chenliu1993 force-pushed the chenliu1993/add_sriov_dp_with_test branch 3 times, most recently from 4b1760c to 29bc97e Compare November 17, 2021 02:40
zhanggbj
zhanggbj previously approved these changes Nov 17, 2021
Copy link
Contributor

@zhanggbj zhanggbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenliu1993
Copy link
Contributor Author

URL lint check is failing because of

 Currently checking  27  url(s) out of  65
Status:  Fail 
URL:     https://github.com/rebuy-de/aws-nuke/releases/download/v2.15.0/aws-nuke-v2.15.0-linux-amd64.tar.gz
Error:   http Status-code 502
Total  1  file(s) contain(s) this URL
File Path: test/install-dependencies.sh
URL Position: 91 : 16

@chenliu1993 chenliu1993 force-pushed the chenliu1993/add_sriov_dp_with_test branch from 7b8fa1a to b6fab64 Compare November 29, 2021 03:45
@seemiller seemiller merged commit 0017bb0 into vmware-tanzu:main Dec 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-not-required owner/docs Work executed by VMware documentation team owner/packages Work executed by a package's maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants