This repository has been archived by the owner on Jun 28, 2023. It is now read-only.
installation: install builder plugin too in windows as part of install script #2398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l script fixes vmware-tanzu#2397 Signed-off-by: Karuppiah Natarajan <[email protected]>
github-actions
bot
added
the
owner/release-eng
davidvonthenen
approved these changes
Oct 29, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Fixes #2397
Details for the Release Notes (PLEASE PROVIDE)
Which issue(s) this PR fixes
Fixes #2397
Describe testing done for PR
--
Special notes for your reviewer
We could add some tests in the future to test
install.batin some way every time there's a change in it. Let me know if you think we should add that as part of this PR and how that would look like - because we need some binaries to install when invokinginstall.batand I think it would be nice to use pre-built binaries, for example the latest TCE release binaries. But yeah, using an older release binaries may not test the script properly if it includes some new features, also will give false results when there are breaking changes in which case the test also has to be updated to use some other set of binaries instead of latest release binaries