This repository has been archived by the owner on Jun 28, 2023. It is now read-only.
Handle empty CLI default config values #2347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initializing the local cluster configuration was checking for the presence of config settings, but not whether they actually contained a value. This is a problem with the real CLI processing since the default values set on all options ends up being "", resulting in default values being used unless passed in as a command line argument. Signed-off-by: Sean McGinnis <[email protected]>
joshrosso
pushed a commit
that referenced
this pull request
Jan 18, 2022
Initializing the local cluster configuration was checking for the presence of config settings, but not whether they actually contained a value. This is a problem with the real CLI processing since the default values set on all options ends up being "", resulting in default values being used unless passed in as a command line argument. Signed-off-by: Sean McGinnis <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initializing the local cluster configuration was checking for the
presence of config settings, but not whether they actually contained a
value. This is a problem with the real CLI processing since the default
values set on all options ends up being "", resulting in default values
being used unless passed in as a command line argument.