This repository has been archived by the owner on Jun 28, 2023. It is now read-only.
Add CLI args for local cluster create and configure #2337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshrosso
reviewed
Oct 25, 2021
| @@ -66,8 +66,6 @@ type LocalClusterConfig struct { | |||
| // PortsToForward contains a mapping of host to container ports that should | |||
| // be exposed. | |||
| PortsToForward []PortMap `yaml:"PortsToForward"` | |||
| // TTY specifies whether the output of commands can be stylized and/or interactive. | |||
| Tty string `yaml:"Tty"` | |||
There was a problem hiding this comment.
I'm pro keeping TTY in the config struct, I'd rather it not get treated in any special way and I can also see a lot of value in allowing TANZU_TTY to be set. Thoughts?
This adds the remaining CLI arguments to the local cluster create and configure commands to be able to provide the most of the configuration to use as part of the command line. Signed-off-by: Sean McGinnis <[email protected]>
stmcginnis
force-pushed
the
sa-overhaul-cli
branch
from
c2a0632 to
41ede71
Compare
stmcginnis
commented
Oct 25, 2021
| } | ||
| clusterConfig, err := config.InitializeConfiguration(configArgs) | ||
| if err != nil { | ||
| log.Errorf("Failed to initialize configuration. Error %s\n", clusterConfig) | ||
| return nil | ||
| } | ||
| ttySetting, err := strconv.ParseBool(clusterConfig.Tty) |
There was a problem hiding this comment.
Note that this was not added back because --tty has a default of true, and CLI arguments take precedent over config and env variables. So basically this will always be whatever co.tty is, so the first logger initialization on line 56 above will never change.
joshrosso
pushed a commit
that referenced
this pull request
Jan 18, 2022
This adds the remaining CLI arguments to the local cluster create and configure commands to be able to provide the most of the configuration to use as part of the command line. Signed-off-by: Sean McGinnis <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the remaining CLI arguments to the local cluster create and
configure commands to be able to provide the most of the configuration
to use as part of the command line.