This repository has been archived by the owner on Jun 28, 2023. It is now read-only.
Implements using ~/.config/tanzu/tkg/local as the config dir for local clusters
#2305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds `getLocalBomPath()` function - Renames `bundle` to `bomImage` in `getTkrBom` function Signed-off-by: John McBride <[email protected]>
joshrosso
pushed a commit
that referenced
this pull request
Jan 18, 2022
- Adds `getLocalBomPath()` function - Renames `bundle` to `bomImage` in `getTkrBom` function Signed-off-by: John McBride <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
All work related to standalone-cluster overhaul and re-implementation
getLocalBomPath()functionbundletobomImageingetTkrBomfunction (which makes more sense since that image isn't a bundle)Details for the Release Notes (PLEASE PROVIDE)
N/a
Which issue(s) this PR fixes
Related to proposal #2266
Describe testing done for PR
rm -rf ~/.config/tanzudirectory~/.config/tanzu/tkg/local/bomand cluster deploys successfullySpecial notes for your reviewer
Open to any and all suggestions regarding variable naming etc!