This repository has been archived by the owner on Jun 28, 2023. It is now read-only.
Implements getting TKR bom from registry #2293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implements DownloadImage for TkrImageReader - Tanzu package now has getTkrBom which uses TkrImageReader to pull in the bom image file Signed-off-by: John McBride <[email protected]>
joshrosso
pushed a commit
that referenced
this pull request
Jan 18, 2022
- Implements DownloadImage for TkrImageReader - Tanzu package now has getTkrBom which uses TkrImageReader to pull in the bom image file Signed-off-by: John McBride <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
All work associated with the standalone-cluster / local cluster overhaul
DownloadImageforTkrImageReaderwhich gets a normal, non-bundle imagetanzupackage now hasgetTkrBomfunction which usesTkrImageReaderto pull in the bom image file. It then does some plumbing to get that file into the correct locationgetTkgBomPathin the tanzu package which gets the desired tanzu bom directory. This is reused in several spotsGetDownloadPathfor theTkrImageReaderwhich returns the path to where a image is / will be downloadedDetails for the Release Notes (PLEASE PROVIDE)
N/a
Which issue(s) this PR fixes
N/a - related to proposal #
Describe testing done for PR
rm -rf ~/.config/tanzu./local create hello-worldand the~/.config/tanzu/tkg/bom/tkr...yamlfile is correctly populatedSpecial notes for your reviewer
N/a