Skip to content
This repository has been archived by the owner on Jun 28, 2023. It is now read-only.

add faq cluster bootstrapping #2143

Merged

Conversation

AlvinRamoutar
Copy link
Contributor

@AlvinRamoutar AlvinRamoutar commented Oct 5, 2021

What this PR does / why we need it

Adding cluster bootstrapping FAQ along with workaround for a common Windows bootstrapping error.

Details for the Release Notes (PLEASE PROVIDE)

- Creating new FAQ cluster bootstrapping subpage
- Adding new FAQ cluster bootstrapping entry for x509: certificate signed by unknown authority when downloading TKG compatibility file error on Windows

Which issue(s) this PR addresses

Addresses: #1398 , #2139

Describe testing done for PR

Tested FAQ successfully on a Windows 10 x64 and Windows Server 2019 x64 host.

@AlvinRamoutar AlvinRamoutar requested a review from a team as a code owner October 5, 2021 05:22
@vmwclabot
Copy link

@AlvinRamoutar, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

@github-actions github-actions bot added the owner/docs Work executed by VMware documentation team label Oct 5, 2021
@github-actions
Copy link

github-actions bot commented Oct 5, 2021

Hi @AlvinRamoutar! And thank you for opening your first Pull Request. Someone will review it soon. Thank you for committing to making Tanzu Community Edition better.

Copy link
Contributor

@jpmcb jpmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AlvinRamoutar! Thanks for opening your first PR and diving head first into this issue! Looks like there are some markdown lint problems. You can run the markdown lint script locally from the root of the repository via while iterating

make mdlint

I'll leave it up to @kcoriordan regarding the formatting and new TOC section

@jpmcb
Copy link
Contributor

jpmcb commented Oct 5, 2021

Fixes: #1398

I don't believe we want that issue to be resolved by this PR. #1398 tracks the original problem when bootstrapping clusters (and captures the now documented workaround from this PR), but we should keep it open so that we can track fixing the root issue

@vmwclabot
Copy link

@AlvinRamoutar, VMware has approved your signed contributor license agreement.

@AlvinRamoutar
Copy link
Contributor Author

Fixes: #1398

I don't believe we want that issue to be resolved by this PR. #1398 tracks the original problem when bootstrapping clusters (and captures the now documented workaround from this PR), but we should keep it open so that we can track fixing the root issue

Agreed. thanks for highlighting this.
I've updated PR OP to 'addresses' rather than fixes.

@AlvinRamoutar
Copy link
Contributor Author

Updated based on mdlint result, please review once more @jpmcb

Copy link
Contributor

@jpmcb jpmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'll leave it to @kcoriordan to comment on the new TOC and top level page

@jpmcb jpmcb requested a review from kcoriordan October 6, 2021 14:23
@kcoriordan
Copy link
Contributor

LGTM - thanks @AlvinRamoutar

@jpmcb jpmcb merged commit d00208f into vmware-tanzu:main Oct 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
owner/docs Work executed by VMware documentation team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants