Skip to content
This repository has been archived by the owner on Jun 28, 2023. It is now read-only.

Post MVP - Day 1: get-tce-release.sh script for public repo #1926

Merged
merged 1 commit into from
Oct 4, 2021

Conversation

jpmcb
Copy link
Contributor

@jpmcb jpmcb commented Sep 23, 2021

What this PR does / why we need it

Modifies the docs and the get-tce-release script to work for a public repo

Details for the Release Notes (PLEASE PROVIDE)

get-tce-release script works for the community edition public repo

Which issue(s) this PR fixes

Follow up to #1855 as we get the auth ready for public release
Follow up to #1442 in order to remove the unnecessary auth steps in the script

Describe testing done for PR

Changed this line:

GH_REPO="$GH_API/repos/vmware-tanzu/community-edition"

to be

GH_REPO="$GH_API/repos/BurntSushi/ripgrep"

and verified the script works to download an asset without the GITHUB_TOKEN env variable for a public repo:

# unset my current token in the envunset GITHUB_TOKEN

# Use the tweeked script to test downloading an asset without a github access token
❯ hack/get-tce-release.sh 13.0.0 ripgrep-13.0.0-x86_64-unknown-linux-musl
Validating dependencies ...
curl is /usr/bin/curl
grep is /usr/bin/grep
sed is /usr/bin/sed
tr is /usr/bin/tr
jq is /usr/bin/jq
Warning: No GITHUB_TOKEN variable defined - requests to the GitHub API may be rate limited
Downloading asset ...
################################################################################# 100.0%

# eagle landed successfully
❯ ls -la 
...
-rw-rw-r--  1 jmcb jmcb 2.1M Sep 23 08:54 ripgrep-13.0.0-x86_64-unknown-linux-musl.tar.gz

We should merge once the repo is public and then verify at that time as well

Special notes for your reviewer

N/a

@jpmcb jpmcb changed the title Post MVP - day 1: get-tce-release script for public repo Post MVP - Day 1: get-tce-release.sh script for public repo Sep 23, 2021
@github-actions github-actions bot added owner/docs Work executed by VMware documentation team owner/release-eng Work executed by VMware release engineering team labels Sep 23, 2021
@jpmcb jpmcb force-pushed the post-mvp-curl-docs branch from 78e3871 to f3fd8fe Compare September 29, 2021 19:47
@jpmcb jpmcb marked this pull request as ready for review October 4, 2021 05:43
@jpmcb jpmcb requested a review from a team as a code owner October 4, 2021 05:43
@jpmcb
Copy link
Contributor Author

jpmcb commented Oct 4, 2021

Ready to merge - but would still be good to test this PR after the repo is made public and tweak any hiccups

@joshrosso joshrosso merged commit c55620b into vmware-tanzu:main Oct 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-not-required owner/docs Work executed by VMware documentation team owner/release-eng Work executed by VMware release engineering team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants