fix: issue #579 (space roles not exported) #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The `addSpaceUsers` function needs the space GUID as a function param, but instead the org GUID is supplied, resulting in no space users being found as the supplied space GUID (which is actually an org GUI) does not actually exist. This commit fixes this issue by correctly supplying the space GUID. - this commit reverses [a past change](1483b66#diff-9982210b028e54f7afea530e407e1544509635e4dae9d236e2045280589b6b65L371) which lacks clear justification (so presumably it's an unintentional change). - backfill an integration test that would have caught this regression. [fixes #579] [https://vmw-jira.broadcom.net/browse/TPCF-27431]
hsinn0
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addSpaceUsersfunction needs the space GUID as a function param, but instead the org GUID is supplied, resulting in no space users being found as the supplied space GUID (which is actually an org GUI) does not actually exist. This commit fixes this issue by correctly supplying the space GUID.[fixes #579]
[https://vmw-jira.broadcom.net/browse/TPCF-27431]