Skip to content
This repository was archived by the owner on Mar 1, 2023. It is now read-only.

Add HEROKU_REGION to configure app region #221

Merged
merged 1 commit into from
Apr 19, 2020
Merged

Add HEROKU_REGION to configure app region #221

merged 1 commit into from
Apr 19, 2020

Conversation

jamesjoshuahill
Copy link
Contributor

Thanks for contributing to postfacto. To speed up the process of reviewing your pull request please provide us with:

  • A short explanation of the proposed change:

    This change enables you to deploy Postfacto to a Heroku region of your choice.
    Run heroku regions to list available regions.

    Given I have set $HEROKU_REGION
    When I run the Heroku deployment script
    Then the app will be deployed into the configured region

    Example:

    HEROKU_REGION='eu' ./deploy.sh <app-name>

    When HEROKU_REGION is not set the app will deploy to the default us region.

  • An explanation of the use cases your change solves

    Allows deployment to the Heroku region nearest to your Postfacto users to reduce latency.

  • Links to any other associated PRs

    None.

  • I have reviewed the contributing guide

  • I have made this pull request to the master branch

  • I have run all the tests using ./test.sh.

  • I have added the copyright headers to each new file added

  • I have given myself credit in the humans.txt file (assuming I want to)

Initial deployments to Heroku will deploy to the us region as before.
Setting HEROKU_REGION='eu' will deploy the app to the eu region.
Run 'heroku regions' for a list of regions.
@pivotal-issuemaster
Copy link

@jamesjoshuahill Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@jamesjoshuahill Thank you for signing the Contributor License Agreement!

@textbook textbook merged commit 11118f2 into vmware-archive:master Apr 19, 2020
@jamesjoshuahill
Copy link
Contributor Author

Thank you @textbook 🙏🏻

@jamesjoshuahill jamesjoshuahill deleted the heroku-region branch April 19, 2020 18:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants