This repository was archived by the owner on Mar 1, 2023. It is now read-only.
Switch image base to alpine #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using alpine rather than the default ubuntu massively reduces the number of CVEs in the final container and reduces the image size
|
This is for the image used for k8s rather than dev right? Good to keep the dev build on Ubuntu I think. |
textbook
approved these changes
Dec 6, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using alpine rather than the default ubuntu massively reduces the number
of CVEs in the final container and reduces the image size
I have reviewed the contributing guide
I have made this pull request to the
masterbranchI have run all the tests using
./test.sh.I have added the copyright headers to each new file added
I have given myself credit in the humans.txt file (assuming I want to)