This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
Start using tox #36
Merged
Start using tox #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sechkova
requested review from
annajung,
difince,
pramodrj07 and
tzstoyanov
as code owners
annajung
approved these changes
Feb 8, 2022
README.md
Outdated
| python -m unittest tests/<file_name> | ||
| ``` | ||
| 8. By using tox |
There was a problem hiding this comment.
nit: I don't think the testing section needs to be numbered as it indicates steps instead of alternatives. could we use bullet points instead?
|
Only the README is updated to replace a numbered list with bullet points. |
|
@sechkova I think you might have to fetch the latest and rebase to get the last check to pass. |
Renamed the main source code path from ml-conversational-analytic-tool to mcat in order to make it a package. Long package names are discouraged and dashes are invalid symbols (see PEP8). Moved tests out of the mcat package and made it a package too. Updated import paths. Updated the auto-generated docs and the README. Signed-off-by: Teodora Sechkova <[email protected]>
Use tox for managing different python virtual environments and running tests. By integrating tox in the CI, the python environment in the CI is reproducible locally. Update the README. Signed-off-by: Teodora Sechkova <[email protected]>
Yeah, I forgot to do that, now it should be ok. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #34
Improve project structure:
Start using tox
The new CI martx runs should be visible in this PR.