This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
Add CIE project #27
Merged
Add CIE project #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olga-kondr
requested review from
annajung,
difince,
enyinna1234,
pramodrj07 and
tzstoyanov
as code owners
|
@olga-kondr, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction. |
annajung
suggested changes
Jan 26, 2022
There was a problem hiding this comment.
hi @olga-kondr can you please clean up hardcoded secrets and force push instead of making a new commit?
difince
reviewed
Jan 28, 2022
annajung
force-pushed
the
cie-project
branch
2 times, most recently
from
c4d1ec1 to
6afdab3
Compare
|
@olga-kondr Thank you for contributing the flaskr/models |
|
@olga-kondr, VMware has approved your signed contributor license agreement. |
|
This lgtm, will leave approval to someone else! thanks @olga-kondr |
|
It needs a couple of tweaks to be able to run out of the box but otherwise looks ok. I guess they can be handled later. |
|
LGTM |
difince
approved these changes
Feb 7, 2022
annajung
approved these changes
Feb 18, 2022
sechkova
approved these changes
Feb 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CIE project has .pdf document that includes project's overview and describes how to run it.