This repository was archived by the owner on Nov 3, 2023. It is now read-only.
Enhance version command #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhiltgen
force-pushed
the
better_version
branch
2 times, most recently
from
1a54dcf to
369aaa0
Compare
Codecov Report
@@ Coverage Diff @@
## main #89 +/- ##
==========================================
+ Coverage 63.82% 65.13% +1.30%
==========================================
Files 40 40
Lines 2737 2825 +88
==========================================
+ Hits 1747 1840 +93
+ Misses 779 761 -18
- Partials 211 224 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This improves the version command to report both client and builder version information.
dhiltgen
force-pushed
the
better_version
branch
from
214d4ad to
2c7c172
Compare
pdevine
approved these changes
Sep 10, 2021
pkg/driver/kubernetes/driver.go
Outdated
| if err != nil { | ||
| return "", err | ||
| } | ||
| // TODO how to timeout if something goes bad...? |
There was a problem hiding this comment.
does remotecommand not support using a context?
There was a problem hiding this comment.
Thanks for asking the question - digging a bit deeper, yes, it looks like it's possible on the Request object. I'll update it.
pdevine
approved these changes
Sep 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the version command to report both client and builder
version information.
Closes #88
Without builder running:
With builder running: