Skip to content
This repository was archived by the owner on Nov 3, 2023. It is now read-only.

Commit

Permalink
Merge pull request #81 from dhiltgen/buildkit_image
Browse files Browse the repository at this point in the history
Refactor BuildKit Image definition
  • Loading branch information
dhiltgen authored Mar 23, 2021
2 parents 98bc545 + 95cbe5f commit 7cb7096
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 11 deletions.
4 changes: 2 additions & 2 deletions pkg/cmd/create.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ import (
"strings"

"github.com/vmware-tanzu/buildkit-cli-for-kubectl/pkg/driver"
"github.com/vmware-tanzu/buildkit-cli-for-kubectl/pkg/driver/bkimage"
"github.com/vmware-tanzu/buildkit-cli-for-kubectl/pkg/driver/kubernetes"
"github.com/vmware-tanzu/buildkit-cli-for-kubectl/pkg/progress"
"github.com/vmware-tanzu/buildkit-cli-for-kubectl/version"

"k8s.io/cli-runtime/pkg/genericclioptions"

Expand Down Expand Up @@ -130,7 +130,7 @@ Driver Specific Usage:
flags.StringVar(&options.configFile, "config", "", "BuildKit config file")
flags.StringArrayVar(&options.platform, "platform", []string{}, "Fixed platforms for current node")
flags.StringVar(&options.progress, "progress", "auto", "Set type of progress output [auto, plain, tty]. Use plain to show container output")
flags.StringVar(&options.image, "image", "", fmt.Sprintf("Specify an alternate buildkit image (default: %s)", bkimage.DefaultImage))
flags.StringVar(&options.image, "image", "", fmt.Sprintf("Specify an alternate buildkit image (default: %s)", version.DefaultImage))
flags.StringVar(&options.runtime, "runtime", "auto", "Container runtime used by cluster [auto, docker, containerd]")
flags.StringVar(&options.containerdSock, "containerd-sock", kubernetes.DefaultContainerdSockPath, "Path to the containerd.sock on the host")
flags.StringVar(&options.containerdNamespace, "containerd-namespace", kubernetes.DefaultContainerdNamespace, "Containerd namespace to build images in")
Expand Down
6 changes: 0 additions & 6 deletions pkg/driver/bkimage/bkimage.go

This file was deleted.

6 changes: 3 additions & 3 deletions pkg/driver/kubernetes/factory.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ import (
"text/template"

"github.com/vmware-tanzu/buildkit-cli-for-kubectl/pkg/driver"
"github.com/vmware-tanzu/buildkit-cli-for-kubectl/pkg/driver/bkimage"
"github.com/vmware-tanzu/buildkit-cli-for-kubectl/pkg/driver/kubernetes/manifest"
"github.com/vmware-tanzu/buildkit-cli-for-kubectl/pkg/driver/kubernetes/podchooser"
"github.com/vmware-tanzu/buildkit-cli-for-kubectl/version"

"github.com/pkg/errors"
"k8s.io/client-go/kubernetes"
Expand Down Expand Up @@ -110,7 +110,7 @@ func (d *Driver) initDriverFromConfig() error {

deploymentOpt := &manifest.DeploymentOpt{
Name: deploymentName,
Image: bkimage.DefaultImage,
Image: version.DefaultImage,
Replicas: 1,
BuildkitFlags: cfg.BuildkitFlags,
Rootless: false,
Expand Down Expand Up @@ -139,7 +139,7 @@ func (d *Driver) initDriverFromConfig() error {
return err
}
if deploymentOpt.Rootless {
deploymentOpt.Image = bkimage.DefaultRootlessImage
deploymentOpt.Image = version.DefaultRootlessImage
}
case "loadbalance":
switch v {
Expand Down
6 changes: 6 additions & 0 deletions version/version.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,12 @@ var (

// Version holds the complete version number. Filled in at linking time.
Version = "v0.0.0+unknown"

// DefaultImage hols the primary build image we use
DefaultImage = "docker.io/moby/buildkit:buildx-stable-1"

// DefaultRootlessImage holds the rootless default image
DefaultRootlessImage = "docker.io/moby/buildkit:buildx-stable-1-rootless"
)

func GetVersionString() string {
Expand Down

0 comments on commit 7cb7096

Please sign in to comment.