Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add platform suffix to files with same name across platforms #148

Merged
merged 1 commit into from
Jun 8, 2018

Conversation

vlovgr
Copy link
Owner

@vlovgr vlovgr commented Jun 8, 2018

Codecov currently has an issue where code coverage doesn't work if you have multiple files with the exact same name in the project. This is an attempt to address that issue by including a platform suffix for files sharing the same name across platforms.

@vlovgr vlovgr force-pushed the platform-suffix branch from 02218ad to 45d54f3 Compare June 8, 2018 10:34
Repository owner deleted a comment from codecov bot Jun 8, 2018
@codecov
Copy link

codecov bot commented Jun 8, 2018

Codecov Report

Merging #148 into master will increase coverage by 4.59%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #148      +/-   ##
==========================================
+ Coverage   95.11%   99.71%   +4.59%     
==========================================
  Files          43       43              
  Lines         696      696              
  Branches        5        5              
==========================================
+ Hits          662      694      +32     
+ Misses         34        2      -32
Impacted Files Coverage Δ
...ciris/refined/decoders/RefinedConfigDecoders.scala 100% <0%> (+100%) ⬆️
...n/scala/ciris/decoders/JavaNetConfigDecoders.scala 100% <0%> (+100%) ⬆️
...ined/jvm/src/main/scala/ciris/refined/syntax.scala 100% <0%> (+100%) ⬆️
...ala/ciris/decoders/JavaNioFileConfigDecoders.scala 100% <0%> (+100%) ⬆️
...in/scala/ciris/ConfigKeyTypePlatformSpecific.scala 100% <0%> (+100%) ⬆️
...ain/scala/ciris/ConfigSourcePlatformSpecific.scala 100% <0%> (+100%) ⬆️
...m/src/main/scala/ciris/CirisPlatformSpecific.scala 100% <0%> (+100%) ⬆️
...in/scala/ciris/decoders/JavaIoConfigDecoders.scala 100% <0%> (+100%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2be5b0a...45d54f3. Read the comment docs.

@vlovgr vlovgr merged commit 00f4e73 into master Jun 8, 2018
@vlovgr vlovgr deleted the platform-suffix branch June 8, 2018 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant