Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix][VLM] Make apply_fp8_linear work with >2D input #9812

Merged
merged 2 commits into from
Oct 30, 2024
Merged

[Bugfix][VLM] Make apply_fp8_linear work with >2D input #9812

merged 2 commits into from
Oct 30, 2024

Conversation

mgoin
Copy link
Member

@mgoin mgoin commented Oct 29, 2024 •
edited
Loading

Needed to work with quantized vision encoders from VLMs. A generalization of the proposed fix in #9800 to all of the cases in apply_fp8_linear

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 29, 2024
@mgoin mgoin changed the title Make apply_fp8_linear work with >2D input [Bugfix][VLM] Make apply_fp8_linear work with >2D input Oct 29, 2024
@mgoin mgoin mentioned this pull request Oct 29, 2024
Merged
tlrmchlsmth
tlrmchlsmth approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@tlrmchlsmth tlrmchlsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we do the same thing in apply_int8_linear?

@simon-mo simon-mo merged commit 226688b into vllm-project:main Oct 30, 2024
58 of 61 checks passed
@DarkLight1337 DarkLight1337 mentioned this pull request Oct 30, 2024
Open
91 tasks
rasmith pushed a commit to rasmith/vllm that referenced this pull request Oct 30, 2024
@mgoin @rasmith
[Bugfix][VLM] Make apply_fp8_linear work with >2D input (vllm-project…
93cd546 
…#9812)

Signed-off-by: Randall Smith <[email protected]>
@gshtras gshtras mentioned this pull request Oct 31, 2024
Closed
NickLucche pushed a commit to NickLucche/vllm that referenced this pull request Oct 31, 2024
@mgoin @NickLucche
[Bugfix][VLM] Make apply_fp8_linear work with >2D input (vllm-project…
d63e563 
…#9812)

Signed-off-by: NickLucche <[email protected]>
NickLucche pushed a commit to NickLucche/vllm that referenced this pull request Oct 31, 2024
@mgoin @NickLucche
[Bugfix][VLM] Make apply_fp8_linear work with >2D input (vllm-project…
1910637 
…#9812)

Signed-off-by: NickLucche <[email protected]>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Nov 4, 2024
@mgoin
[Bugfix][VLM] Make apply_fp8_linear work with >2D input (vllm-project…
f458512 
…#9812)
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Nov 4, 2024
@mgoin
[Bugfix][VLM] Make apply_fp8_linear work with >2D input (vllm-project…
a3d724c 
…#9812)

Signed-off-by: Linkun Chen <[email protected]>
hissu-hyvarinen pushed a commit to ROCm/vllm that referenced this pull request Nov 6, 2024
@mgoin @hissu-hyvarinen
[Bugfix][VLM] Make apply_fp8_linear work with >2D input (vllm-project…
ceca1e5 
…#9812)
JC1DA pushed a commit to JC1DA/vllm that referenced this pull request Nov 11, 2024
@mgoin @JC1DA
[Bugfix][VLM] Make apply_fp8_linear work with >2D input (vllm-project…
bdb9d50 
…#9812)

Signed-off-by: Loc Huynh <[email protected]>
sumitd2 pushed a commit to sumitd2/vllm that referenced this pull request Nov 14, 2024
@mgoin @sumitd2
[Bugfix][VLM] Make apply_fp8_linear work with >2D input (vllm-project…
14c6e99 
…#9812)

Signed-off-by: Sumit Dubey <[email protected]>
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
@mgoin
[Bugfix][VLM] Make apply_fp8_linear work with >2D input (vllm-project…
ab30312 
…#9812)
mfournioux pushed a commit to mfournioux/vllm that referenced this pull request Nov 20, 2024
@mgoin @mfournioux
[Bugfix][VLM] Make apply_fp8_linear work with >2D input (vllm-project…
4385d9b 
…#9812)

Signed-off-by: Maxime Fournioux <[email protected]>
tlrmchlsmth pushed a commit to neuralmagic/vllm that referenced this pull request Nov 23, 2024
@mgoin @tlrmchlsmth
[Bugfix][VLM] Make apply_fp8_linear work with >2D input (vllm-project…
9632e20 
…#9812)

Signed-off-by: Tyler Michael Smith <[email protected]>
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
@mgoin
[Bugfix][VLM] Make apply_fp8_linear work with >2D input (vllm-project…
0bf80b9 
…#9812)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlrmchlsmth tlrmchlsmth tlrmchlsmth approved these changes

@comaniac comaniac comaniac approved these changes

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat robertgshaw2-redhat is a code owner

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mgoin @tlrmchlsmth @comaniac @simon-mo