[Doc] Consistent naming of attention backends #9498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Parnell <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
comaniac
approved these changes
Oct 18, 2024
Signed-off-by: Thomas Parnell <[email protected]>
mgoin
approved these changes
Oct 20, 2024
|
Please take a look at the CI failure. |
Signed-off-by: Thomas Parnell <[email protected]>
auto-merge was automatically disabled
October 21, 2024 09:00
Head branch was pushed to by a user without write access
|
@DarkLight1337 CI issues are fixed now. |
charlifu
pushed a commit
to charlifu/vllm
that referenced
this pull request
Oct 23, 2024
Signed-off-by: Thomas Parnell <[email protected]> Signed-off-by: charlifu <[email protected]>
vrdn-23
pushed a commit
to vrdn-23/vllm
that referenced
this pull request
Oct 23, 2024
Signed-off-by: Thomas Parnell <[email protected]> Signed-off-by: Vinay Damodaran <[email protected]>
Alvant
pushed a commit
to compressa-ai/vllm
that referenced
this pull request
Oct 26, 2024
Signed-off-by: Thomas Parnell <[email protected]> Signed-off-by: Alvant <[email protected]>
garg-amit
pushed a commit
to garg-amit/vllm
that referenced
this pull request
Oct 28, 2024
Signed-off-by: Thomas Parnell <[email protected]> Signed-off-by: Amit Garg <[email protected]>
FerdinandZhong
pushed a commit
to FerdinandZhong/vllm
that referenced
this pull request
Oct 29, 2024
Signed-off-by: Thomas Parnell <[email protected]> Signed-off-by: qishuai <[email protected]>
sumitd2
pushed a commit
to sumitd2/vllm
that referenced
this pull request
Nov 14, 2024
Signed-off-by: Thomas Parnell <[email protected]> Signed-off-by: Sumit Dubey <[email protected]>
KuntaiDu
pushed a commit
to KuntaiDu/vllm
that referenced
this pull request
Nov 20, 2024
Signed-off-by: Thomas Parnell <[email protected]>
mfournioux
pushed a commit
to mfournioux/vllm
that referenced
this pull request
Nov 20, 2024
Signed-off-by: Thomas Parnell <[email protected]> Signed-off-by: Maxime Fournioux <[email protected]>
tlrmchlsmth
pushed a commit
to neuralmagic/vllm
that referenced
this pull request
Nov 23, 2024
Signed-off-by: Thomas Parnell <[email protected]> Signed-off-by: Tyler Michael Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now if you try to enable an unsupported feature (e.g., multi-step with xformers) you get a message like:
I find this confusing because the names given do not match how the environment variable needs to be set in order to enable the corresponding feature (e.g.
rocm-flash-attnvs.ROCM_FLASH). The actual names are all-caps and defined by this enum. Those values do not match the string "names" defined in each attention backend class.This PR fixes this, so the user will be suggested a list of strings that will actually work.