Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Cleanup & refactor Dockerfile to pass different Python versions and sccache bucket via build args #7705

Merged
merged 9 commits into from
Aug 22, 2024

Conversation

khluu
Copy link
Collaborator

@khluu khluu commented Aug 20, 2024

  • Clean up unused commands
  • Pack dependencies installation into as few commands as possible so Docker can cache it better
  • Install flashinfer based on Python version passed in instead of fixing it to 3.10
  • Make SCCACHE_BUCKET and SCCACHE_REGION build arg (with default set to vllm's bucket and region)

p
Signed-off-by: kevin <[email protected]>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

khluu added 3 commits August 20, 2024 22:31
p
Signed-off-by: kevin <[email protected]>
p
Signed-off-by: kevin <[email protected]>
p
Signed-off-by: kevin <[email protected]>
@njhill
Copy link
Member

njhill commented Aug 21, 2024

@khluu maybe you could also check #7525 in case you didn't see it

@khluu
Copy link
Collaborator Author

khluu commented Aug 21, 2024

@khluu maybe you could also check #7525 in case you didn't see it

My PR doesn't really touch the dependencies like #7525. It's more like a small refactoring to cleanup stuff & allow different sccache bucket or python version to be passed in via build args so we can run CI with different versions (for example flashinfer python version is fixed to 3.10 so we can't test anything else).

khluu added 3 commits August 21, 2024 04:14
p
Signed-off-by: kevin <[email protected]>
p
Signed-off-by: kevin <[email protected]>
p
Signed-off-by: kevin <[email protected]>
@khluu khluu changed the title [NOT-FOR-REVIEW] Refactor Dockerfike [ci] Cleanup & refactor Dockerfile to pass different Python versions and sccache bucket Aug 21, 2024
@khluu khluu requested a review from simon-mo August 21, 2024 07:52
p
Signed-off-by: kevin <[email protected]>
@khluu khluu changed the title [ci] Cleanup & refactor Dockerfile to pass different Python versions and sccache bucket [ci] Cleanup & refactor Dockerfile to pass different Python versions and sccache bucket via build args Aug 21, 2024
@aslonnie aslonnie self-requested a review August 21, 2024 21:43
Copy link
Collaborator

@simon-mo simon-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we lost TORCH_CUDA_ARCH_LIST but it is still needed to build cross platform wheels I believe

p
Signed-off-by: kevin <[email protected]>
@khluu khluu added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 22, 2024
@khluu
Copy link
Collaborator Author

khluu commented Aug 22, 2024

I think we lost TORCH_CUDA_ARCH_LIST but it is still needed to build cross platform wheels I believe

Ok I'll just bring it back.. we can clean it up later on

@khluu khluu enabled auto-merge (squash) August 22, 2024 18:22
@khluu khluu merged commit 666ad0a into vllm-project:main Aug 22, 2024
65 of 67 checks passed
omrishiv pushed a commit to omrishiv/vllm that referenced this pull request Aug 26, 2024
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
…and sccache bucket via build args (vllm-project#7705)

Signed-off-by: kevin <[email protected]>
Signed-off-by: Alvant <[email protected]>
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants