-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Cleanup & refactor Dockerfile to pass different Python versions and sccache bucket via build args #7705
Conversation
Signed-off-by: kevin <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge). To run full CI, you can do one of these:
🚀 |
Signed-off-by: kevin <[email protected]>
Signed-off-by: kevin <[email protected]>
Signed-off-by: kevin <[email protected]>
My PR doesn't really touch the dependencies like #7525. It's more like a small refactoring to cleanup stuff & allow different sccache bucket or python version to be passed in via build args so we can run CI with different versions (for example flashinfer python version is fixed to 3.10 so we can't test anything else). |
Signed-off-by: kevin <[email protected]>
Signed-off-by: kevin <[email protected]>
Signed-off-by: kevin <[email protected]>
Signed-off-by: kevin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we lost TORCH_CUDA_ARCH_LIST
but it is still needed to build cross platform wheels I believe
Signed-off-by: kevin <[email protected]>
Ok I'll just bring it back.. we can clean it up later on |
…and sccache bucket via build args (vllm-project#7705) Signed-off-by: kevin <[email protected]>
…and sccache bucket via build args (vllm-project#7705) Signed-off-by: kevin <[email protected]> Signed-off-by: Alvant <[email protected]>
…and sccache bucket via build args (vllm-project#7705) Signed-off-by: kevin <[email protected]>
3.10
SCCACHE_BUCKET
andSCCACHE_REGION
build arg (with default set to vllm's bucket and region)